Skip to content

gh-132684: [Enum] only call _missing_ in __contains__ for Flags #132790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2025
Merged

gh-132684: [Enum] only call _missing_ in __contains__ for Flags #132790

merged 2 commits into from
Apr 25, 2025

Conversation

ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Apr 22, 2025 •
edited by bedevere-app bot
Loading

@ethanfurman ethanfurman added type-bug An unexpected behavior, bug, or error skip news stdlib Python modules in the Lib dir 3.13 bugs and security fixes 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Apr 22, 2025
@ethanfurman ethanfurman self-assigned this Apr 22, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 22, 2025
Closed
@ethanfurman ethanfurman requested a review from picnixz April 22, 2025 16:46
picnixz
picnixz reviewed Apr 24, 2025
View reviewed changes
@ethanfurman @picnixz
simplify code
2122e59 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
picnixz reviewed Apr 24, 2025
View reviewed changes
picnixz
picnixz reviewed Apr 24, 2025
View reviewed changes
@ethanfurman ethanfurman merged commit 22bc953 into python:main Apr 25, 2025
42 checks passed
@miss-islington-app
Copy link

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 25, 2025
@ethanfurman @picnixz @miss-islington
pythongh-132684: [Enum] only call _missing_ in __contains__ for Flags (…
d898299 
…pythonGH-132790)

(cherry picked from commit 22bc953)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 25, 2025

GH-132896 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 25, 2025
ethanfurman added a commit that referenced this pull request Apr 25, 2025
@miss-islington @ethanfurman @picnixz
[3.13] gh-132684: [Enum] only call _missing_ in __contains__ for Flags (
0877222 
GH-132790) (GH-132896)

gh-132684: [Enum] only call _missing_ in __contains__ for Flags (GH-132790)
(cherry picked from commit 22bc953)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@hugovk hugovk removed 3.13 bugs and security fixes 3.14 bugs and security fixes labels May 21, 2025
@ambv ambv added the needs backport to 3.12 only security fixes label Jun 3, 2025
@miss-islington-app
Copy link

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @ethanfurman, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 22bc953aa9be3039629dd1315f856d2522619412 3.12

@ambv
Copy link
Contributor

ambv commented Jun 3, 2025

Backporting the fix is not trivial. I get 22 failed tests after. Let's not touch 3.12 then.

@ambv ambv removed the needs backport to 3.12 only security fixes label Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

Assignees

@ethanfurman ethanfurman

Labels
skip news stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanfurman @ambv @picnixz @hugovk