gh-134152: Fix UnboundLocalError in email._header_value_parser _get_ptext_to_endchars #134233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these tests currently pass, where the content is simply empty. Three of them fail, where none of the ending delimiters are found.
gpshead
approved these changes
May 25, 2025
|
Thanks @bitdancer for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @bitdancer for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 25, 2025
…_get_ptext_to_endchars (pythonGH-134233) Fix an UnboundLocalError that can occur when parsing certain delimited constructs in headers (domain literals, quoted strings, comments). After the fix the _get_ptext_to_endchars returns an empty string if there is no content after the opening delimiter. The calling code is responsible for handling the lack of the trailing delimiter, which it already does; this edge case was the header ending immediately after the opening delimiter. (cherry picked from commit a32ea45) Co-authored-by: R. David Murray <rdmurray@bitdance.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 25, 2025
…_get_ptext_to_endchars (pythonGH-134233) Fix an UnboundLocalError that can occur when parsing certain delimited constructs in headers (domain literals, quoted strings, comments). After the fix the _get_ptext_to_endchars returns an empty string if there is no content after the opening delimiter. The calling code is responsible for handling the lack of the trailing delimiter, which it already does; this edge case was the header ending immediately after the opening delimiter. (cherry picked from commit a32ea45) Co-authored-by: R. David Murray <rdmurray@bitdance.com>
|
GH-134677 is a backport of this pull request to the 3.13 branch. |
|
GH-134678 is a backport of this pull request to the 3.14 branch. |
hugovk
pushed a commit
that referenced
this pull request
May 26, 2025
hugovk
pushed a commit
that referenced
this pull request
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an UnboundLocalError that can occur when parsing certain delimited constructs in headers (domain literals, quoted strings, comments). After the fix the _get_ptext_to_endchars returns an empty string if there is no content after the opening delimiter. The calling code is responsible for handling the lack of the trailing delimiter, which it already does; this edge case was the header ending immediately after the opening delimiter.
UnboundLocalErrorinemail._header_value_parser.parse_message_id#134152