gh-87720 Fix additional header refolding-quoting edge case #134271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, the higher level syntactic unit fit on the remainder of the line in un-encoded format, so the encoding check never happened. To fix this, we look inside the current unit to see if has anything that was originally encoded.
|
@medmunds Do you feel like reviewing this? :) |
|
medmunds
approved these changes
May 26, 2025
There was a problem hiding this comment.
This fix LGTM. But I found another corner case while looking at it. Here's the failing test:
--- a/Lib/test/test_email/test__header_value_parser.py (revision ebde4e897750963b82bcae785949ac11b3877640)
+++ b/Lib/test/test_email/test__header_value_parser.py (date 1748289921461)
@@ -3101,6 +3101,8 @@
'=?utf-8?q?a=2C?=\n'
' 123456789012345678901234567890123456\n'
' <abc@example.com>\n'),
+ ('abc@example.com (, but definitely not also sent to def@example.net)',
+ 'abc@example.com (, but definitely not\n also sent to def@example.net)\n'),
]
for (to, folded) in cases:
with self.subTest(to=to):(This case belongs in a new test covering comment folding, but you'll get the point. Guessing I should open a new issue—it's more like the earlier quoted-string problem. I bring it up here in case it might help you spot other xtext variations needing attention.)
(Also, is this on Seth's radar yet?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, the higher level syntactic unit fit on the remainder of the line in un-encoded format, so the encoding check never happened. To fix this, we look inside the current unit to see if has anything that was originally encoded.
I'm not really happy with the method name 'has_token_type', but I haven't thought of anything I like better. Ideas welcome.