Skip to content

gh-74232: Adds note about csv quoting of booleans #134422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

aterrel
Copy link

@aterrel aterrel commented May 21, 2025

@@ -333,6 +333,9 @@ The :mod:`csv` module defines the following constants:

Instructs :class:`reader` objects to convert all non-quoted fields to type *float*.

```True``` and ```False``` are numeric types in Python so using this option will
Copy link
Contributor

@Yzi-Li Yzi-Li May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```True``` and ```False``` are numeric types in Python so using this option will
``True`` and ``False`` are numeric types in Python so using this option will

```True``` is markdown syntax, it should be ``True`` in RST documentation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will update.

@aterrel aterrel requested a review from Yzi-Li May 31, 2025 02:50
Copy link
Contributor

@Yzi-Li Yzi-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @serhiy-storchaka is interested in this.

@serhiy-storchaka
Copy link
Member

The issues is not only with booleans, and not only with QUOTE_NONNUMERIC. I created other PR #134963.

@aterrel
Copy link
Author

aterrel commented Jun 1, 2025

@serhiy-storchaka okay I was just resolving the one issue. I'll close this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants