Heavily comment Python/perf_jit_trampoline.c to improve maintainability #134527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@savannahostrowski @brandtbucher 
Eh eh, wrong JIT wrong JIT 😆 |
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 9, 2025
…ty (pythonGH-134527) (cherry picked from commit 7b1a700) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
|
GH-135299 is a backport of this pull request to the 3.14 branch. |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 9, 2025
…ty (pythonGH-134527) (cherry picked from commit 7b1a700) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
|
GH-135300 is a backport of this pull request to the 3.13 branch. |
|
@pablogsal: This change isn't only about comments, it also fix test_perf_profiler, especially if commit 899cca6 is applied on top of it. So I propose to backport it to 3.13 and 3.14 branches. |
pablogsal
pushed a commit
that referenced
this pull request
Jun 9, 2025
pablogsal
pushed a commit
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.