-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-133579: correctly report C curses errors in _curses_panel
#134629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-133579: correctly report C curses errors in _curses_panel
#134629
Conversation
_curses_panel
_curses_panel
…tter-errors-125843
Looks good! Sorry for the delay. |
🤖 New build scheduled with the buildbot fleet by @encukou for commit e6c00d0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134629%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buildbot failures are unrelated.
I don't mind keeping the comment in. Do you really want to remove it?
Not really, though I think I can remove it if we go through all modules that don't correctly assert this (but in a follow-up). In practice, I don't think it'll be an issue as such functions are internal-only, so issues would be caught at review time. We could do more expensive checks on DEBUG builds though. I think I wanted to remove it because I expected that this issue was already well-known and that my comment could have been "too much". |
So let's merge this as is? |
I assign the PR to myself when I want to merge it later, otherwise I forget about the PR. But if you want to merge it before, you can go ahead! |
Also, I myself only merge stuff when I'm on Linux as I can revert or make a fast patch if something breaks just after (I'm currently on Windows since I'm playing). So usually I merge my PRs when I'm back on Linux. |
This was part of #125844 but I extracted it from there because it wasn't necessary. I'll make it part of gh-133579 instead of gh-125843 because the other one was more for curses module itself and this one is a follow-up (and also because I changed some exception types)
curses
C function failures #133579