Skip to content

GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 #134660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2025
Merged

GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 #134660

merged 1 commit into from
May 25, 2025

Conversation

chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented May 25, 2025 •
edited by bedevere-app bot
Loading

Fixes the WindowsConsoleGetEventTests which got broken due to moving wait into get_event in WindowsConsole during #133728.

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels May 25, 2025
@ambv ambv changed the title fix WindowsConsoleGetEventTests after PR-133728 GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 May 25, 2025
@ambv ambv removed the skip issue label May 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 25, 2025
Closed
@ambv
Copy link
Contributor

ambv commented May 25, 2025

!buildbot Windows10

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ambv for commit 7f15126 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134660%2Fmerge

The command will test the builders whose names match following regular expression: Windows10

The builders matched are:

  • AMD64 Windows10 PR

@ambv
Copy link
Contributor

ambv commented May 25, 2025

Buildbot looks happy now!

@ambv ambv merged commit 1000283 into python:main May 25, 2025
49 checks passed
@ambv ambv added awaiting review needs backport to 3.14 bugs and security fixes labels May 25, 2025
@miss-islington-app
Copy link

Thanks @chris-eibl for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2025
@chris-eibl @miss-islington
pythonGH-130328: Fix WindowsConsoleGetEventTests after pythongh-133728 (
0422edf 
pythongh-134660)

(cherry picked from commit 1000283)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 25, 2025

GH-134666 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 25, 2025
ambv pushed a commit that referenced this pull request May 25, 2025
@miss-islington @chris-eibl
[3.14] GH-130328: Fix WindowsConsoleGetEventTests after gh-133728 (gh…
6917fbf 
…-134660) (gh-134666)

(cherry picked from commit 1000283)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
@chris-eibl chris-eibl deleted the fix_WindowsConsoleGetEventTests branch May 26, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
awaiting review skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-eibl @ambv @bedevere-bot