[3.14] gh-134531: cleanup _hashopenssl.c to support EVP_MAC (GH-134626)
#134703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nGH-134626) Rename components related to `_hashlib.{HASH,HASHXOF}` objects. - The `EVPobject` structure is renamed `HASHobject`. - Non-clinic `HASH` methods are now prefixed by `_hashlib_HASH_*`. A similar change is made for non-clinic `HASHXOF` methods. - Functions extracting information from `EVP_MD` objects and functions constructing `EVP_MD` objects now include `openssl_evp_md` in their name. This change allows us to avoid future ambiguities between the `EVP_MD` and the `EVP_MAC` APIs (currently, we only use `EVP_MD` for hash functions and rely on the legacy interface for HMAC instead of using `EVP_MAC`). (cherry picked from commit cb8045e) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
I'm a bit hesistant now... On one's side, it will ease my life when handling conflicts, but.... at the same time, because of the additional complexity of EVP_MAC in the file, I actually think I'll anyway have conflicts. So to be on the safe side (and since the beta is near), I'll just forget all backports and will just keep it in 3.15 for now. If there are issues later, we can apply those changes first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename components related to
_hashlib.{HASH,HASHXOF}objects.EVPobjectstructure is renamedHASHobject.HASHmethods are now prefixed by_hashlib_HASH_*.A similar change is made for non-clinic
HASHXOFmethods.EVP_MDobjects and functionsconstructing
EVP_MDobjects now includeopenssl_evp_mdin their name.This change allows us to avoid future ambiguities between the
EVP_MDand the
EVP_MACAPIs (currently, we only useEVP_MDfor hash functionsand rely on the legacy interface for HMAC instead of using
EVP_MAC).(cherry picked from commit cb8045e)
Co-authored-by: Bénédikt Tran 10796600+picnixz@users.noreply.github.com