Skip to content

gh-134830: Fix reference in Doc/extending/windows.rst #134831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2025
Merged

gh-134830: Fix reference in Doc/extending/windows.rst #134831

merged 5 commits into from
Jun 2, 2025

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented May 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels May 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 28, 2025
@StanFromIreland StanFromIreland changed the title Fix reference in Doc/extending/windows.rst gh-134830: Fix reference in Doc/extending/windows.rst May 28, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 28, 2025
Open
@befeleme
Copy link
Contributor

Unfortunately this didn't help:
https://cpython-previews--134831.org.readthedocs.build/en/134831/extending/stable-abi

URL        `stable-abi'
Name       `Limited API'
Parent URL file:///builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/windows.html, line 277, col 5
Real URL   file:///builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/stable-abi
Check time 0.001 seconds
Result     Error: URLError: <urlopen error [Errno 2] No such file or directory: '/builddir/build/BUILD/python3-docs-3.14.0_b2-build/Python-3.14.0b2/Doc/build/html/extending/stable-abi'>

@StanFromIreland
Copy link
Contributor Author

Ah yes, I somehow did not notice that it wasn't a reference in the first place.

@befeleme
Copy link
Contributor

Perhaps the reference should be still point to the original <stable-application-binary-interface> as it refers to the whole section, rather that the sub-one?

hroncok
hroncok reviewed May 29, 2025
View reviewed changes
@StanFromIreland @hroncok
Suggestion
2619d81 
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@hroncok
Copy link
Contributor

hroncok commented May 29, 2025 •
edited
Loading

So, the problem is, the reference does not exist. It needs to be added to Doc/c-api/stable.rst

Above

cpython/Doc/c-api/stable.rst

Line 55 in e64395e

Stable Application Binary Interface

I cannot do that by suggestion.

@StanFromIreland StanFromIreland requested a review from encukou as a code owner May 29, 2025 11:39
@encukou
Copy link
Member

encukou commented Jun 2, 2025

Is this the only issue in Doc/using/windows.rst? If it is, the file should be removed from Doc/tools/.nitignore.

(I'm away from the computer now, will be able to check tomorrow)

@StanFromIreland
Copy link
Contributor Author

If there are other issues I don’t mind fixing them all, I can get to it later in the week.

@encukou
Copy link
Member

encukou commented Jun 2, 2025

I checked; some nitpicks about environment variables remain.
Thank you for the improvement!

@encukou encukou merged commit 0ac9e17 into python:main Jun 2, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jun 2, 2025
@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 2, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 3, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2025
@StanFromIreland @hroncok @miss-islington
pythongh-134830: Fix reference in Doc/extending/windows.rst (python…
04f607d 
…GH-134831)

(cherry picked from commit 0ac9e17)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@miss-islington-app
Copy link

Sorry, @StanFromIreland and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ac9e17fb47075c9446b99da4dffe4cad993b97a 3.13

@bedevere-app
Copy link

bedevere-app bot commented Jun 3, 2025

GH-135058 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 3, 2025
@encukou encukou removed the needs backport to 3.13 bugs and security fixes label Jun 3, 2025
encukou pushed a commit that referenced this pull request Jun 3, 2025
@miss-islington @StanFromIreland @hroncok
[3.14] gh-134830: Fix reference in Doc/extending/windows.rst (GH-13…
d420d82 
…4831) (GH-135058)

(cherry picked from commit 0ac9e17)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
@StanFromIreland StanFromIreland deleted the link branch June 3, 2025 07:14
@StanFromIreland
Copy link
Contributor Author

I will check them out later.

Apologies I am unable to backport:-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroncok hroncok hroncok approved these changes

@befeleme befeleme befeleme approved these changes

@encukou encukou Awaiting requested review from encukou encukou is a code owner

Assignees

@encukou encukou

Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StanFromIreland @befeleme @hroncok @encukou