All commit authors signed the Contributor License Agreement.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

I think the those tests are only failing because compilation fails on gcc-10. I'll have a look and see if I can obtain a copy and will update accordingly.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@cakemanny one small comment: we squash merge so there is no need to rebase. It's easier to review if you just add commits on top so we don't need to review the full thing every iteration :)

I have made the requested changes; please review again

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

Excellent job @cakemanny 🚀

Thanks @cakemanny for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

GH-135240 is a backport of this pull request to the 3.14 branch.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit ac9c343.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/11555) and take a look at the build logs.
4. Check if the failure is related to this commit (ac9c343) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/11555

Failed tests:

• test_tokenize
• test.test_concurrent_futures.test_thread_pool
• test.test_multiprocessing_forkserver.test_misc
• test_math

Failed subtests:

• test_lock - test.test_multiprocessing_forkserver.test_misc.TestForkAwareThreadLock.test_lock
• test_random_files - test.test_tokenize.TestRoundtrip.test_random_files
• test_sumprod_stress - test.test_math.MathTests.test_sumprod_stress

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tokenize.py", line 2027, in test_random_files
    self.check_roundtrip(f)
    ~~~~~~~~~~~~~~~~~~~~^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tokenize.py", line 1860, in check_roundtrip
    self.assertEqual(tokens2_from2, tokens2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: [(68,[121084 chars]'), (55, '.'), (1, '_box'), (4, ''), (6, ''), (6, ''), (0, '')] != [(68,[121084 chars]'), (55, '.'), (1, '_box')]


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/_test_multiprocessing.py", line 5658, in test_lock
    new_size = r.recv()
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/connection.py", line 256, in recv
    buf = self._recv_bytes()
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/connection.py", line 447, in _recv_bytes
    buf = self._recv(4)
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/multiprocessing/connection.py", line 416, in _recv
    raise EOFError
EOFError


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_math.py", line 1471, in test_sumprod_stress
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        run(baseline_sumprod, *args),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        run(sumprod, *args),
        ^^^^^^^^^^^^^^^^^^^^
        args,
        ^^^^^
    )
    ^
AssertionError: Tuples differ: (None, <class 'float'>, '181.59375') != (None, <class 'float'>, '161.59375')


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tokenize.py", line 2027, in test_random_files
    self.check_roundtrip(f)
    ~~~~~~~~~~~~~~~~~~~~^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tokenize.py", line 1860, in check_roundtrip
    self.assertEqual(tokens2_from2, tokens2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: [(68,[23523 chars]'\n')] != [(68,[23523 chars]'\n'), (1, 'then'), (55, '='), (1, 'time'), (5[3888 chars] '')]

The failures on that buildbot don't look like they should be related to my changes.
I saw in https://buildbot.python.org/#/builders/345/builds/11547 test_math had a re-run recently, so I guess that one could be flaky sometimes?
And test_multiprocessing_forkserver is listed under expected transient failures: https://devguide.python.org/testing/buildbots/index.html#transient-failures .

test_tokenize failure is rather puzzling though.
Unless remote debugging is being used as part of the test infrastructure I guess it also cannot be related?

I think all I would be able to do right now would be to keep an eye open on subsequent runs.