Skip to content

gh-134869: Fix Ctrl+C corrupts REPL autocomplete #134929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 18, 2025
Merged

gh-134869: Fix Ctrl+C corrupts REPL autocomplete #134929

merged 9 commits into from
Aug 18, 2025
+2 −0

Conversation

ggqlq
Copy link
Contributor

@ggqlq ggqlq commented May 30, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 30, 2025
Open
@ggqlq ggqlq changed the title gh-134869: Fix Ctrl+C corrupts autocomplete gh-134869: Fix Ctrl+C corrupts REPL autocomplete May 31, 2025
picnixz
picnixz reviewed Aug 18, 2025
View reviewed changes
Lib/_pyrepl/simple_interact.py Outdated
@@ -158,6 +158,10 @@ def maybe_run_command(statement: str) -> bool:
input_n += 1
except KeyboardInterrupt:
r = _get_reader()
r.cmpltn_menu_visible = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call r.cmpltn_reset() instead.

@picnixz
Copy link
Member

picnixz commented Aug 18, 2025

Please add a NEWS entry under the Library section (this makes me wonder whether we actually need a separate section or rename IDLE to "IDLE & REPL", though it's a separate issue)

picnixz
picnixz approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me but I'm not a REPL expert so there might be some other stuff to care about. cc @pablogsal

@pablogsal
Copy link
Member

Tested this locally and works. I cannot see anything wrong with it and as testing this is going to be very complicated I am fine to merge as is. We can add a test later if someone sees a way to test this that won't be too annoying.

@pablogsal
Copy link
Member

Good job @ggqlq 🚀

@pablogsal pablogsal merged commit 8750e5e into python:main Aug 18, 2025
56 checks passed
@pablogsal pablogsal added awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 18, 2025
@miss-islington-app
Copy link

Thanks @ggqlq for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @ggqlq for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2025
@ggqlq @miss-islington
pythongh-134869: Fix Ctrl+C corrupts REPL autocomplete (pythonGH-134929)
0958d0f 
(cherry picked from commit 8750e5e)

Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2025
@ggqlq @miss-islington
pythongh-134869: Fix Ctrl+C corrupts REPL autocomplete (pythonGH-134929)
84d76a2 
(cherry picked from commit 8750e5e)

Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 18, 2025

GH-137925 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 18, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 18, 2025

GH-137926 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 18, 2025
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
pablogsal pushed a commit that referenced this pull request Aug 18, 2025
@miss-islington @ggqlq
[3.13] gh-134869: Fix Ctrl+C corrupts REPL autocomplete (GH-134929) (#…
b372565 
…137925)

gh-134869: Fix Ctrl+C corrupts REPL  autocomplete (GH-134929)
(cherry picked from commit 8750e5e)

Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
pablogsal pushed a commit that referenced this pull request Aug 18, 2025
@miss-islington @ggqlq
[3.14] gh-134869: Fix Ctrl+C corrupts REPL autocomplete (GH-134929) (#…
5034b64 
…137926)

gh-134869: Fix Ctrl+C corrupts REPL  autocomplete (GH-134929)
(cherry picked from commit 8750e5e)

Co-authored-by: ggqlq <124190229+ggqlq@users.noreply.github.com>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@ggqlq @Agent-Hellboy
pythongh-134869: Fix Ctrl+C corrupts REPL autocomplete (python#134929)
e2e6ff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggqlq @picnixz @pablogsal @bedevere-bot