Skip to content

[3.14] gh-134696: align OpenSSL and HACL*-based hash functions constructors AC signatures (GH-134713) #134961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented May 31, 2025

OpenSSL and HACL*-based hash functions constructors now support both data and string parameters. Previously these constructor functions inconsistently supported sometimes data and sometimes string, while the documentation expected data to be given in all cases.

(cherry picked from commit c6e63d9 and 379d0bc)

…constructors AC signatures (pythonGH-134713)

OpenSSL and HACL*-based hash functions constructors now support both `data` and `string` parameters.
Previously these constructor functions inconsistently supported sometimes `data` and sometimes `string`,
while the documentation expected `data` to be given in all cases.

(cherry picked from commit c6e63d9)
(cherry picked from commit 379d0bc)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz force-pushed the backport-c6e63d9-3.14 branch from 622dea0 to ab91460 Compare May 31, 2025 13:18
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 31, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @gpshead for commit ab91460 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134961%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 31, 2025
@picnixz picnixz merged commit 777fd49 into python:3.14 Jun 1, 2025
119 of 121 checks passed
@picnixz picnixz deleted the backport-c6e63d9-3.14 branch June 1, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants