-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-134978: deprecate string
keyword parameter for hash function constructors
#134979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-134978: deprecate string
keyword parameter for hash function constructors
#134979
Conversation
Oh I forgot to update hashlib.rst |
005a637
to
996992d
Compare
996992d
to
26f01fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets extend the timeline longer than our minimal 2 years. how about 3.19?
@@ -94,6 +94,13 @@ accessible by name via :func:`new`. See :data:`algorithms_available`. | |||
OpenSSL does not provide we fall back to a verified implementation from | |||
the `HACL\* project`_. | |||
|
|||
.. deprecated-removed:: 3.15 3.19 | |||
The undocumented ``string`` keyword parameter in :func:`!_hashlib.new` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deprecation note is about the private interface (except for the public hashlib.sha3_*
, 'string' was only present in private functions), so I still mentioned this here. There were too many situations where people complained that a deprecation note was only in present in the What's New or changelog, but not in the page documenting the functions (though in this case, the only documented functions being affected are sha3_*
or hashlib.new + sha3 + HACL*
)
|
string
named-parameter in hash functions constructors #134978📚 Documentation preview 📚: https://cpython-previews--134979.org.readthedocs.build/