Skip to content

gh-134989: Implement PyObject_DelAttr() as a macro in the limited C API #135021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

gh-134989: Implement PyObject_DelAttr() as a macro in the limited C API #135021

merged 1 commit into from
Jun 4, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 2, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 2, 2025
Closed
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 2, 2025
@vstinner
Copy link
Member Author

vstinner commented Jun 2, 2025

cc @serhiy-storchaka @encukou

serhiy-storchaka
serhiy-storchaka approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@encukou encukou merged commit c211130 into python:main Jun 4, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @vstinner for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2025
@vstinner @miss-islington
pythongh-134989: Implement PyObject_DelAttr() as a macro in the limit…
0433420 
…ed C API (pythonGH-135021)

(cherry picked from commit c211130)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington-app
Copy link

Sorry, @vstinner and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c21113072cd1f0da83729f99d3576647db85d816 3.13

@encukou
Copy link
Member

encukou commented Jun 4, 2025

Thank you!

@bedevere-app
Copy link

bedevere-app bot commented Jun 4, 2025

GH-135133 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 4, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 4, 2025

GH-135134 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 4, 2025
vstinner added a commit to vstinner/cpython that referenced this pull request Jun 4, 2025
@vstinner
pythongh-134989: Implement PyObject_DelAttr() as a macro in the limit…
5246905 
…ed C API (pythonGH-135021)

(cherry picked from commit c211130)
@vstinner vstinner deleted the object_delattr branch June 4, 2025 13:33
vstinner added a commit that referenced this pull request Jun 4, 2025
@miss-islington @vstinner
[3.14] gh-134989: Implement PyObject_DelAttr() as a macro in the limi…
da1bbce 
…ted C API (GH-135021) (#135133)

gh-134989: Implement PyObject_DelAttr() as a macro in the limited C API (GH-135021)
(cherry picked from commit c211130)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jun 4, 2025
@vstinner
[3.13] gh-134989: Implement PyObject_DelAttr() as a macro in the limi…
95f6296 
…ted C API (GH-135021) (#135134)

gh-134989: Implement PyObject_DelAttr() as a macro in the limited C API (GH-135021)

(cherry picked from commit c211130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@encukou encukou

Labels
topic-C-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @encukou @serhiy-storchaka