gh-135101: When choosing the default simulator device, don't use simctl --set testing
#135102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This was referenced Jun 3, 2025
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit d07659e 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135102%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742
approved these changes
Jun 4, 2025
| @@ -127,7 +127,7 @@ async def async_check_output(*args, **kwargs): | |||
| async def select_simulator_device(): | |||
| # List the testing simulators, in JSON format | |||
There was a problem hiding this comment.
Suggested change
| # List the testing simulators, in JSON format | |
| # List the testing simulators, in JSON format. Use the full list, not just | |
| # the testing set; on a fresh install (or in CI), the testing set may be empty. |
There was a problem hiding this comment.
Dangit... forgot to merge this suggestion. I've got some other cleanups I need to make in the general area; I'll add it in then.
|
Thanks @joerick for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2025
…e `simctl --set testing` (pythonGH-135102) On a fresh Xcode install (including some CI provider configurations), there is no pre-existing testing set that can be used to identify simulator models. Use the default device set to detect available models instead. Live testing simulators are still created in the testing set. (cherry picked from commit dba9de7) Co-authored-by: Joe Rickerby <joerick@mac.com>
|
GH-135113 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2025
…e `simctl --set testing` (pythonGH-135102) On a fresh Xcode install (including some CI provider configurations), there is no pre-existing testing set that can be used to identify simulator models. Use the default device set to detect available models instead. Live testing simulators are still created in the testing set. (cherry picked from commit dba9de7) Co-authored-by: Joe Rickerby <joerick@mac.com>
|
GH-135114 is a backport of this pull request to the 3.13 branch. |
freakboy3742
pushed a commit
that referenced
this pull request
Jun 4, 2025
…se `simctl --set testing` (GH-135102) (#135114) On a fresh Xcode install (including some CI provider configurations), there is no pre-existing testing set that can be used to identify simulator models. Use the default device set to detect available models instead. Live testing simulators are still created in the testing set. (cherry picked from commit dba9de7) Co-authored-by: Joe Rickerby <joerick@mac.com>
freakboy3742
pushed a commit
that referenced
this pull request
Jun 4, 2025
…se `simctl --set testing` (GH-135102) (#135113) On a fresh Xcode install (including some CI provider configurations), there is no pre-existing testing set that can be used to identify simulator models. Use the default device set to detect available models instead. Live testing simulators are still created in the testing set. (cherry picked from commit dba9de7) Co-authored-by: Joe Rickerby <joerick@mac.com>
freakboy3742
pushed a commit
to freakboy3742/cpython
that referenced
this pull request
Jun 4, 2025
…on't use `simctl --set testing` (pythonGH-135102) (python#135113) On a fresh Xcode install (including some CI provider configurations), there is no pre-existing testing set that can be used to identify simulator models. Use the default device set to detect available models instead. Live testing simulators are still created in the testing set. (cherry picked from commit dba9de7) Co-authored-by: Joe Rickerby <joerick@mac.com>
freakboy3742
pushed a commit
to freakboy3742/cpython
that referenced
this pull request
Jun 4, 2025
…on't use `simctl --set testing` (pythonGH-135102) (python#135114) On a fresh Xcode install (including some CI provider configurations), there is no pre-existing testing set that can be used to identify simulator models. Use the default device set to detect available models instead. Live testing simulators are still created in the testing set. (cherry picked from commit dba9de7) Co-authored-by: Joe Rickerby <joerick@mac.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the error seen in pypa/cibuildwheel#2443 .
I don't know what
--set testingis doing, but the previous default deviceiPhone SE (3rd edition)was not listed there either, and omitting the flag seems to list all the devices that the SDK knows about, rather than ones previously used for testing.cc @freakboy3742