-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Fix definition of _Py_RemoteDebug_
symbols for static linking
#135146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I'm happy to include a news entry and issue if desired, we chatted about this problem briefly in Discord and I figured I'd just quickly post the patch. |
CI has some compiler warnings
|
Yeah this file is included in two places but they don't use all the functions. We must silence these warnings because they are false positives |
No need. This is not a user visible change and it doesn't really qualify as a bug fix (depends how you look at it). I am happy either way basically |
@pablogsal I've silenced the warnings. |
Hummm, I still see the warnings in GitHub in the https://github.com/python/cpython/pull/135146/files page. Is this expected? |
Yeah I think so? I'm not familiar with the warnings tooling, but I believe I've just followed the "standard" way to silence new warnings in a file. If there's another way, we'll need to hear from someone who's an owner of such things :) |
Maybe set this:
|
Yeah, as @pablogsal suggests, I'd use diagnostic pragmas to silence these warnings (because MSVC does not feature Lines 297 to 302 in c740fe3
which might be suitable to use / extend. I'd furthermore suggest to enable the warnings again using |
On a second thought please scratch my suggestion above. If using
works like @pablogsal suggested above, then we're fine, since suppress
Sorry for the noise. |
As noted at
cpython/Python/remote_debug.h
Line 9 in 01bb53d
python-build-standalone
), e.g.: