Skip to content

gh-134160: Use PyModuleDef.m_free in the example module xxlimited #135174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2025
Merged

gh-134160: Use PyModuleDef.m_free in the example module xxlimited #135174

merged 3 commits into from
Jun 6, 2025
+8 −3

Conversation

encukou
Copy link
Member

@encukou encukou commented Jun 5, 2025 •
edited by bedevere-app bot
Loading

The comment about free not being necessary is wrong. Like classes, modules need both clear and free.

@bedevere-app bedevere-app bot mentioned this pull request Jun 5, 2025
Open
@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 5, 2025
neonene
neonene reviewed Jun 6, 2025
View reviewed changes
@encukou @neonene
Update Modules/xxlimited.c
f89c4fb 
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
@encukou encukou enabled auto-merge (squash) June 6, 2025 11:48
vstinner
vstinner approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You should merge main into your branch to retrieve the test_syntax fix.

@encukou encukou merged commit 1adca08 into python:main Jun 6, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2025
@encukou @neonene @miss-islington
pythongh-134160: Use PyModuleDef.m_free in the example module xxlimit…
cff4bbf 
…ed (pythonGH-135174)

(cherry picked from commit 1adca08)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 6, 2025
@encukou @neonene @miss-islington
pythongh-134160: Use PyModuleDef.m_free in the example module xxlimit…
986354f 
…ed (pythonGH-135174)

(cherry picked from commit 1adca08)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 6, 2025

GH-135213 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 6, 2025

GH-135214 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 6, 2025
encukou added a commit that referenced this pull request Jun 6, 2025
@miss-islington @encukou @neonene
[3.14] gh-134160: Use PyModuleDef.m_free in the example module xxlimi…
dd4a819 
…ted (GH-135174) (GH-135213)

gh-134160: Use PyModuleDef.m_free in the example module xxlimited (GH-135174)
(cherry picked from commit 1adca08)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
@encukou encukou deleted the xxlimited-free branch June 7, 2025 09:03
encukou added a commit that referenced this pull request Jun 7, 2025
@miss-islington @encukou @neonene
[3.13] gh-134160: Use PyModuleDef.m_free in the example module xxlimi…
7620805 
…ted (GH-135174) (GH-135214)

gh-134160: Use PyModuleDef.m_free in the example module xxlimited (GH-135174)
(cherry picked from commit 1adca08)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonene neonene neonene left review comments

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@encukou @vstinner @neonene