gh-135177: Add assert to catch potential overflow #135179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Jun 5, 2025
| @@ -1236,6 +1236,7 @@ _Py_call_instrumentation_jump( | |||
| event == PY_MONITORING_EVENT_BRANCH_RIGHT || | |||
| event == PY_MONITORING_EVENT_BRANCH_LEFT); | |||
| int to = (int)(dest - _PyFrame_GetBytecode(frame)); | |||
| assert(to <= INT_MAX / (int)sizeof(_Py_CODEUNIT)); | |||
There was a problem hiding this comment.
If there is a real risk that this case occurs, I would prefer to raise an exception.
There was a problem hiding this comment.
Do you mean something like this?
if (to <= INT_MAX / (int)sizeof(_Py_CODEUNIT)) {
PyErr_SetString(PyExc_OverflowError, "instruction offset is too large for int");
return NULL;
}There was a problem hiding this comment.
I will close this one request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an assertion to the _Py_call_instrumentation_jump function to catch potential integer overflow in the expression
to * (int)sizeof(_Py_CODEUNIT).