Skip to content

gh-131798: Optimize _UNARY_INVERT #135222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

gh-131798: Optimize _UNARY_INVERT #135222

wants to merge 9 commits into from
+53 −1

Conversation

noamcohen97
Copy link
Contributor

@noamcohen97 noamcohen97 commented Jun 6, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 6, 2025
Open
Fidget-Spinner
Fidget-Spinner approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

brandtbucher
brandtbucher approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you add a test for the bool case?

@noamcohen97
Copy link
Contributor Author

Thanks for reviewing @brandtbucher and @Fidget-Spinner.
I added a test case for booleans

@brandtbucher
Copy link
Member

Hm, I didn't realize we had deprecated bitwise inversion on bool. Let's just drop bool from the optimizer, it's not worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noamcohen97 @brandtbucher @Fidget-Spinner