Skip to content

gh-135234: improve _hashlib exceptions when reporting an OpenSSL function failure #135250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 9, 2025
+199 −122
Merged

gh-135234: improve _hashlib exceptions when reporting an OpenSSL function failure #135250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
eb3cb2e
add helpers for setting exceptions
picnixz Jun 8, 2025
e242865
refactor `get_openssl_evp_md_by_utf8name` error branches
picnixz Jun 8, 2025
ac6dea4
refactor `HASH.{digest,hexdigest}` computations
picnixz Jun 8, 2025
4bc2808
refactor `_hashlib_HASH_copy_locked` and `locked_HMAC_CTX_copy`
picnixz Jun 8, 2025
14b87df
set remaining exceptions after an OpenSSL failure
picnixz Jun 8, 2025
e5b2ef3
blurb
picnixz Jun 8, 2025
5b41242
wrap OpenSSL context allocators
picnixz Jun 8, 2025
2a8cf55
fix compilation, remove unused functions and update messages
picnixz Jun 8, 2025
ea2ce0e
update wrappers
picnixz Jun 8, 2025
43739c5
align exception messages
picnixz Jun 8, 2025
e226431
context allocators can only set an ERR_R_MALLOC_FAILURE error
picnixz Jun 8, 2025
7201e0a
update exception message for `get_openssl_evp_md_by_utf8name`
picnixz Jun 8, 2025
f8c2aed
refactor logic for mapping NIDs to EVP_MD objects
picnixz Jun 8, 2025
380f5a0
Update Modules/_hashopenssl.c
picnixz Jun 8, 2025
7036df8
remove TODO
picnixz Jun 8, 2025
b7f0947
Merge branch 'refactor/hashlib/evp-nid-interface-134531' into feat/ha…
picnixz Jun 8, 2025
a1066fe
pull main
picnixz Jun 8, 2025
76c7dd2
Merge branch 'main' into feat/hashlib/smart-exceptions-135234
picnixz Jun 8, 2025
35e6d1e
Update Misc/NEWS.d/next/Library/2025-06-08-11-11-07.gh-issue-135234.w…
picnixz Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2025-06-08-11-11-07.gh-issue-135234.wJCdh0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
:mod:`hashlib`: improve exception messages when an OpenSSL function failed.
When memory allocation fails on OpenSSL's side, a :exc:`MemoryError` is
raised instead of a :exc:`ValueError`. Patch by Bénédikt Tran.
Loading
Loading