gh-118350: Fix support of elements "textarea" and "title" in HTMLParser #135310

timonviola · 2025-06-09T18:42:10Z

This is a PR where comments and tests are implemented based on feedback from the draft PR: #121770

Issue: HTMLParser does not support escapable raw text mode (<textarea> and <title>) #118350

Issue: HTMLParser differences from the HTML5 specification #135661

serhiy-storchaka · 2025-06-25T13:22:59Z

There are more fundamental issues in HTMLParser (see #135661). I'll review this PR after fixing them.

serhiy-storchaka · 2025-07-04T11:31:25Z

There were more fundamental issues in HTMLParser (see #135661). Now many of them are fixed, and the rest should not conflict with this PR. Please update the PR. Tests for style and script were rewritten, so please make tests for title and textarea similar to them.

serhiy-storchaka · 2025-07-14T17:18:07Z

There were some errors in the implementations -- it was not able to find the closing tag and did not work with convert_charrefs=True. I fixed this and refactored the code and the tests.

This issue is now classified as a security issue, like many other HTMLParser issues.

miss-islington-app · 2025-07-22T11:27:17Z

Thanks @timonviola for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖

…MLParser (pythonGH-135310) (cherry picked from commit 4d02f31) Co-authored-by: Timon Viola <44016238+timonviola@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app · 2025-07-22T11:27:35Z

GH-136985 is a backport of this pull request to the 3.13 branch.

miss-islington-app · 2025-07-22T11:27:38Z

Sorry, @timonviola and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4d02f31cdd45d81b95540d9076222b709d4f2335 3.11

bedevere-app · 2025-07-22T11:27:42Z

GH-136986 is a backport of this pull request to the 3.12 branch.

miss-islington-app · 2025-07-22T11:27:42Z

Sorry, @timonviola and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4d02f31cdd45d81b95540d9076222b709d4f2335 3.10

miss-islington-app · 2025-07-22T11:27:46Z

Sorry, @timonviola and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4d02f31cdd45d81b95540d9076222b709d4f2335 3.9

…TMLParser (GH-135310) (GH-136984) (cherry picked from commit 4d02f31) Co-authored-by: Timon Viola <44016238+timonviola@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

…TMLParser (GH-135310) (GH-136985) (cherry picked from commit 4d02f31) Co-authored-by: Timon Viola <44016238+timonviola@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

…TMLParser (GH-135310) (GH-136986) (cherry picked from commit 4d02f31) Co-authored-by: Timon Viola <44016238+timonviola@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

…" in HTMLParser (pythonGH-135310) (pythonGH-136986) (cherry picked from commit 4d02f31) Co-authored-by: Timon Viola <44016238+timonviola@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl> Signed-off-by: Michał Górny <mgorny@gentoo.org>

…MLParser (python#135310) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

Backports for PR python/cpython#135310 were merged including 3.12 branch

Python 3.13.6 changed the way `<title>` tags are parsed: If there is no end tag, the rest of document is handled as title content. Source: python/cpython#135310 This change has also been backported to Python 3.12 but is not yet released. Example of a breaking test: https://github.com/zopefoundation/groktoolkit/actions/runs/16882111176/job/47820322945?pr=102 (Sorry I was not able to reproduce it here in the repository but I also saw it locally on 3.13.6)

Python 3.13.6 changed the way `<title>` tags are parsed: If there is no end tag, the rest of document is handled as title content. Source: python/cpython#135310 This change has also been backported to Python 3.12 but is not yet released. Example of a breaking test: https://github.com/zopefoundation/groktoolkit/actions/runs/16882111176/job/47820322945?pr=102 (Sorry I was not able to reproduce it here in the repository but I also saw it locally on 3.13.6) – The difference is that groktoolkit already uses uv (which already has 3.13.6) and zope.tal still relies on the Python versions provided by GitHub Actions (which does not yet have it.)

…" in HTMLParser (pythonGH-135310) (cherry picked from commit 4d02f31) Co-authored-by: Timon Viola <44016238+timonviola@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app · 2025-08-14T21:02:31Z

GH-137782 is a backport of this pull request to the 3.11 branch.

…" in HTMLParser (pythonGH-135310) (cherry picked from commit 4d02f31) Co-authored-by: Timon Viola <44016238+timonviola@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app · 2025-08-14T21:03:52Z

GH-137783 is a backport of this pull request to the 3.10 branch.

… in HTMLParser (pythonGH-135310) (cherry picked from commit 4d02f31) Co-authored-by: Timon Viola <44016238+timonviola@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

bedevere-app · 2025-08-14T21:05:41Z

GH-137784 is a backport of this pull request to the 3.9 branch.

timonviola added 2 commits June 9, 2025 20:24

fix: fix html parser raw text escapable mode

b7900cd

docs: add blurb new fragment

8f60744

timonviola requested a review from ezio-melotti as a code owner June 9, 2025 18:42

bedevere-app bot added the awaiting review label Jun 9, 2025

bedevere-app bot mentioned this pull request Jun 9, 2025

HTMLParser does not support escapable raw text mode (<textarea> and <title>) #118350

Closed

timonviola mentioned this pull request Jun 9, 2025

gh-118350: Add escapable-raw-text mode to html parser #121770

Closed

serhiy-storchaka self-requested a review June 9, 2025 20:07

serhiy-storchaka self-assigned this Jun 25, 2025

serhiy-storchaka added 5 commits July 14, 2025 10:18

Merge branch 'main' into fix-issue-118350-2

4a9ad26

Fix errors and rewrite tests.

7824ee8

Refactoring.

18c6ea8

Update the NEWS entry.

051516a

Reclassify

c93a771

serhiy-storchaka changed the title ~~gh-118350: Add escapable-raw-text to CDATA mode~~ gh-118350: Fix support of elements "textarea" and "title" in HTMLParser Jul 14, 2025

Update 2025-06-09-20-38-25.gh-issue-118350.KgWCcP.rst

a27159f

serhiy-storchaka mentioned this pull request Jul 22, 2025

HTMLParser differences from the HTML5 specification #135661

Open

Make escapable= kwarg-only

5681bbc

ambv merged commit 4d02f31 into python:main Jul 22, 2025
41 checks passed

bedevere-app bot removed the awaiting review label Jul 22, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 22, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 22, 2025

miss-islington-app bot assigned ambv and unassigned serhiy-storchaka Jul 22, 2025

bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 22, 2025

donBarbos added a commit to donBarbos/typeshed that referenced this pull request Aug 7, 2025

[html] Reflect parser backports

dd66c35

Backports for PR python/cpython#135310 were merged including 3.12 branch

donBarbos mentioned this pull request Aug 7, 2025

Fix stdlib stubtest for 3.13.6 patch release python/typeshed#14543

Merged

icemac mentioned this pull request Aug 13, 2025

Fix tests for Python 3.13.6+ compatibility. zopefoundation/zope.tal#22

Merged

bedevere-app bot removed the needs backport to 3.11 only security fixes label Aug 14, 2025

bedevere-app bot removed the needs backport to 3.10 only security fixes label Aug 14, 2025

bedevere-app bot removed the needs backport to 3.9 only security fixes label Aug 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-118350: Fix support of elements "textarea" and "title" in HTMLParser #135310

gh-118350: Fix support of elements "textarea" and "title" in HTMLParser #135310

Uh oh!

timonviola commented Jun 9, 2025 •

edited by serhiy-storchaka

Loading

Uh oh!

serhiy-storchaka commented Jun 25, 2025

Uh oh!

serhiy-storchaka commented Jul 4, 2025

Uh oh!

serhiy-storchaka commented Jul 14, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Jul 22, 2025

Uh oh!

bedevere-app bot commented Jul 22, 2025

Uh oh!

miss-islington-app bot commented Jul 22, 2025

Uh oh!

bedevere-app bot commented Jul 22, 2025

Uh oh!

miss-islington-app bot commented Jul 22, 2025

Uh oh!

miss-islington-app bot commented Jul 22, 2025

Uh oh!

bedevere-app bot commented Aug 14, 2025

Uh oh!

bedevere-app bot commented Aug 14, 2025

Uh oh!

bedevere-app bot commented Aug 14, 2025

Uh oh!

Uh oh!

Uh oh!

gh-118350: Fix support of elements "textarea" and "title" in HTMLParser #135310

gh-118350: Fix support of elements "textarea" and "title" in HTMLParser #135310

Uh oh!

Conversation

timonviola commented Jun 9, 2025 • edited by serhiy-storchaka Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka commented Jun 25, 2025

Uh oh!

serhiy-storchaka commented Jul 4, 2025

Uh oh!

serhiy-storchaka commented Jul 14, 2025

Uh oh!

Uh oh!

miss-islington-app bot commented Jul 22, 2025

Uh oh!

bedevere-app bot commented Jul 22, 2025

Uh oh!

miss-islington-app bot commented Jul 22, 2025

Uh oh!

bedevere-app bot commented Jul 22, 2025

Uh oh!

miss-islington-app bot commented Jul 22, 2025

Uh oh!

miss-islington-app bot commented Jul 22, 2025

Uh oh!

bedevere-app bot commented Aug 14, 2025

Uh oh!

bedevere-app bot commented Aug 14, 2025

Uh oh!

bedevere-app bot commented Aug 14, 2025

Uh oh!

Uh oh!

timonviola commented Jun 9, 2025 •

edited by serhiy-storchaka

Loading