Skip to content

gh-130077: Properly match full soft keywords in the parser #135317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

gh-130077: Properly match full soft keywords in the parser #135317

merged 1 commit into from
Jun 10, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 9, 2025 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 9, 2025
@pablogsal pablogsal requested a review from lysnikolaou as a code owner June 9, 2025 22:55
@pablogsal pablogsal added needs backport to 3.14 bugs and security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 9, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 9, 2025
Open
@pablogsal pablogsal mentioned this pull request Jun 9, 2025
Closed
lysnikolaou
lysnikolaou approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal pablogsal merged commit ff2b5f4 into python:main Jun 10, 2025
43 checks passed
@pablogsal pablogsal deleted the gh-130077 branch June 10, 2025 13:19
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 10, 2025
@pablogsal @miss-islington
pythongh-130077: Properly match full soft keywords in the parser (pyt…
0243b19 
…honGH-135317)

(cherry picked from commit ff2b5f40c2bf5c71255caac8a743c09ba0758c02)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ff2b5f40c2bf5c71255caac8a743c09ba0758c02 3.13

@bedevere-app
Copy link

bedevere-app bot commented Jun 10, 2025

GH-135348 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 10, 2025
@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ff2b5f40c2bf5c71255caac8a743c09ba0758c02 3.12

pablogsal added a commit that referenced this pull request Jun 11, 2025
@miss-islington @pablogsal
[3.14] gh-130077: Properly match full soft keywords in the parser (GH…
77c4b5d 
…-135317) (#135348)

gh-130077: Properly match full soft keywords in the parser (GH-135317)
(cherry picked from commit ff2b5f4)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 11, 2025

GH-135399 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 11, 2025
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jun 11, 2025
@pablogsal
[3.13] pythongh-130077: Properly match full soft keywords in the pars…
dccc750 
…er (pythonGH-135317)

(cherry picked from commit ff2b5f4)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 11, 2025

GH-135400 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 11, 2025
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jun 11, 2025
@pablogsal
[3.12] pythongh-130077: Properly match full soft keywords in the pars…
64b4b11 
…er (pythonGH-135317)

(cherry picked from commit ff2b5f4)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablogsal @lysnikolaou