Skip to content

gh-133264: Correct documentation of how Py_Main and Py_RunMain handle SystemExit #135337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2025
Merged

gh-133264: Correct documentation of how Py_Main and Py_RunMain handle SystemExit #135337

merged 3 commits into from
Jun 11, 2025
+8 −22

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Jun 10, 2025 •
edited by github-actions bot
Loading

@mhsmith mhsmith requested a review from vstinner June 10, 2025 09:36
@mhsmith mhsmith added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 10, 2025
@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir labels Jun 10, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jun 10, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 10, 2025
Closed
@mhsmith mhsmith force-pushed the py-runmain-systemexit branch from 92560de to 4d8a45b Compare June 10, 2025 09:39
vstinner
vstinner approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit b706ff0 into python:main Jun 11, 2025
28 checks passed
@miss-islington-app
Copy link

Thanks @mhsmith for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jun 11, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2025
@mhsmith @miss-islington
pythongh-133264: Correct documentation of how Py_Main and Py_RunMain …
a5788f7 
…handle SystemExit (pythonGH-135337)

(cherry picked from commit b706ff0)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 11, 2025

GH-135394 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2025
@mhsmith @miss-islington
pythongh-133264: Correct documentation of how Py_Main and Py_RunMain …
1b98f7e 
…handle SystemExit (pythonGH-135337)

(cherry picked from commit b706ff0)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 11, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 11, 2025

GH-135395 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 11, 2025
vstinner pushed a commit that referenced this pull request Jun 11, 2025
@miss-islington @mhsmith
[3.14] gh-133264: Correct documentation of how Py_Main and Py_RunMain…
98136dd 
… handle SystemExit (GH-135337) (#135394)

gh-133264: Correct documentation of how Py_Main and Py_RunMain handle SystemExit (GH-135337)
(cherry picked from commit b706ff0)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
vstinner pushed a commit that referenced this pull request Jun 11, 2025
@miss-islington @mhsmith
[3.13] gh-133264: Correct documentation of how Py_Main and Py_RunMain…
d24d925 
… handle SystemExit (GH-135337) (#135395)

gh-133264: Correct documentation of how Py_Main and Py_RunMain handle SystemExit (GH-135337)
(cherry picked from commit b706ff0)

Co-authored-by: Malcolm Smith <smith@chaquo.com>
@vstinner
Copy link
Member

Merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsmith @vstinner