Skip to content

gh-131876: extract _hashlib helpers into a separate directory [WIP] #135341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

gh-131876: extract _hashlib helpers into a separate directory [WIP] #135341

wants to merge 3 commits into from
+250 −459

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jun 10, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 10, 2025
Open
@picnixz
Copy link
Member Author

picnixz commented Jun 10, 2025

!buildbot FIPS only

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit c90722e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135341%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

@picnixz picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch from cb8ac17 to b213a79 Compare June 10, 2025 11:32
@picnixz
Copy link
Member Author

picnixz commented Jun 10, 2025

Ok. This is too messy. I'll need to think about it differently.

@picnixz picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch 2 times, most recently from 52f5e58 to 6b2f58d Compare June 10, 2025 12:41
@picnixz picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch 3 times, most recently from 7d8bd5f to 11b0d3c Compare June 10, 2025 13:03
@picnixz picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch from 11b0d3c to 0692ccc Compare June 10, 2025 13:05
@picnixz
Copy link
Member Author

picnixz commented Jun 10, 2025 •
edited
Loading

Ok, for now it seems to work on Linux/macOS. Still need to figure out why it fails on WASI and Windows but I have my little idea.

picnixz
picnixz commented Jun 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead will be requested when the pull request is marked ready for review gpshead is a code owner

@tiran tiran Awaiting requested review from tiran tiran will be requested when the pull request is marked ready for review tiran is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti will be requested when the pull request is marked ready for review ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk will be requested when the pull request is marked ready for review hugovk is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @bedevere-bot