gh-135361: update documentation for remote_debugger_script audit event
#135362
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t event Signed-off-by: Manjusaka <me@manjusaka.me>
vstinner
previously approved these changes
Jun 11, 2025
There was a problem hiding this comment.
LGTM
The audit event is logged in Python/ceval_gil.c:
static inline void run_remote_debugger_script(PyObject *path)
{
if (0 != PySys_Audit("remote_debugger_script", "O", path)) {
PyErr_FormatUnraisable(
"Audit hook failed for remote debugger script %U", path);
return;
}
...|
cc @pablogsal |
I misunderstood the audit event. It's recorded by the debugged process. The documentation should clarify that.
vstinner
reviewed
Jun 11, 2025
| @@ -1933,6 +1933,8 @@ always available. Unless explicitly noted otherwise, all variables are read-only | |||
| interpreter is pre-release (alpha, beta, or release candidate) then the | |||
| local and remote interpreters must be the same exact version. | |||
|
|
|||
There was a problem hiding this comment.
I misunderstood the audit event. It's recorded by the debugged process. The documentation should clarify that.
Or maybe the audit event should also be logged by the process which calls sys.remote_exec().
There was a problem hiding this comment.
I can update and add more info, BTW I think we can logged the event at both side
There was a problem hiding this comment.
I think we should get an audit event in sys.remote_exec() yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #135361