Skip to content

gh-133982: Use implementation-specific open in test_fileio OtherFileTests #135364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmaloney
Copy link
Contributor

@cmaloney cmaloney commented Jun 10, 2025

The tests around unicode filenames use both FileIO directly and open so kept using open for them / validates that unicode filenames passed through open() match behavior of FileIO called directly with an encoded name.

For the append tests it looks like FileIO directly is closer to what was intended, there is test_io that has append tests around self.open directly, this is test_fileio so intent I think was to test FileIO directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants