gh-133982: Use implementation-specific open in test_fileio OtherFileTests #135364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests around unicode filenames use both
FileIO
directly andopen
so kept usingopen
for them / validates that unicode filenames passed throughopen()
match behavior ofFileIO
called directly with an encoded name.For the append tests it looks like FileIO directly is closer to what was intended, there is
test_io
that has append tests aroundself.open
directly, this istest_fileio
so intent I think was to test FileIO directly.