gh-135307: Fix email error when policy max_line_length is set to 0 or None #135367
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] main from python:main
Misc/NEWS.d/next/Library/2025-06-10-18-02-29.gh-issue-135307.fXGrcK.rst
Outdated
Show resolved
Hide resolved
|
Haha, nice catch lol |
| def test_no_wrapping_with_none_max_line_length(self): | ||
| pol = policy.default.clone(max_line_length=None) | ||
| subj = "S" * 100 | ||
| body = "B" * 100 |
There was a problem hiding this comment.
Maybe we should use some bigger number? Because word "unlimited" is present. Something like 10**7, for example.
There was a problem hiding this comment.
I don't think it's necessary, here we just want to test if it will wrap the context to the default 78 characters. 0 / None is set it to no wrap mode. This is a similar fix logic as _refold_parse_tree so I mentioned 'unlimited' as there, but it actually takes sys.maxsize. Thanks for comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
email.policy.Policy.max_line_lengthis falsey #135307