gh-135368: Fix mocks on dataclass specs with instance=True
#135421
Conversation
Extend dataclass mock_methods
|
All commit authors signed the Contributor License Agreement. |
Not fully sure what's going on there as I've singed the CLA already. There are a handful of merged PRs from me with the same Github user email, e.g. #130191. -- |
Because of the way GitHub messes with authorship on merges, the CLA also needs to be signed for the noted address (I believe there's an option to tie it to a real address for CLA purposes, but this is an area I'm not that familiar with). |
Just clicked on the link above and signed it again although I can even see the Legacy PSF Contributor Agreement there too. Oh well 🤷🏻♂️ Should be all good now. |
…ythonGH-135421) * pythongh-135368: Fix mocks on dataclass specs with `instance=True` * Extend dataclass mock_methods --------- (cherry picked from commit c8319a3fea9ff7f9b49008be3b5d681112bbe7f3) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
|
GH-135503 is a backport of this pull request to the 3.14 branch. |
|
Did this need to go the 3.13 or earlier too? |
|
Thank you! No, #124429 was never backported to 3.13, because it was a new feature. |
…H-135421) (#135503) gh-135368: Fix mocks on dataclass specs with `instance=True` (GH-135421) * gh-135368: Fix mocks on dataclass specs with `instance=True` * Extend dataclass mock_methods --------- (cherry picked from commit c8319a3) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
cc @ncoghlan, @cdce8p
This brings back two features mentioned in #135368
__class____dataclass_*__featuresBasically, the fix is rather obvious: we just set the proper fields.
__annotations__has changed due to__annotate__function, this is not our fault :)I also have a revert PR ready, if this one is not good enough.
Refs #124429