Fix doc braino #135431
Merged
Fix doc braino #135431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nope, the next line starts with "is a mapping". The main branch currently
renders as "whose value is a dictionary is a mapping of attribute names";
with my change it renders as "whose value is a mapping of attribute names".
Granted the line break isn't placed intuitively :-)
…On Thu, Jun 12, 2025 at 8:07 AM Stan Ulbrych ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Doc/library/logging.config.rst
<#135431 (comment)>:
> @@ -548,7 +548,7 @@ mnemonic that the corresponding value is a callable.
The ``filters`` member of ``handlers`` and ``loggers`` can take
filter instances in addition to ids.
-You can also specify a special key ``'.'`` whose value is a dictionary is a
+You can also specify a special key ``'.'`` whose value is a
⬇️ Suggested change
-You can also specify a special key ``'.'`` whose value is a
+You can also specify a special key ``'.'`` whose value is a dictionary
From my understanding you removed too much, and this was intended.
—
Reply to this email directly, view it on GitHub
<#135431 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAYSMHOK2ZPO7CD3BRC2L3DGJR5AVCNFSM6AAAAAB7FTMQOSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSMRRGYYTCNZTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ZeroIntensity
approved these changes
Jun 12, 2025
vsajip
approved these changes
Jun 12, 2025
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 12, 2025
(cherry picked from commit f273fd7) Co-authored-by: Eric Hanchrow <eric.hanchrow@gmail.com>
|
GH-135440 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 12, 2025
(cherry picked from commit f273fd7) Co-authored-by: Eric Hanchrow <eric.hanchrow@gmail.com>
|
GH-135441 is a backport of this pull request to the 3.13 branch. |
vsajip
pushed a commit
that referenced
this pull request
Jun 13, 2025
vsajip
pushed a commit
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just nix two words that probably shouldn't be there.
📚 Documentation preview 📚: https://cpython-previews--135431.org.readthedocs.build/