gh-133403: Check generate_stdlib_module_names and check_extension_modules with mypy
#137546
+65
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsion_modules` with mypy
hugovk
approved these changes
Aug 12, 2025
Comment on lines
+20
to
+21
|
|
||
| from __future__ import annotations |
There was a problem hiding this comment.
Suggested change
| from __future__ import annotations | |
| from __future__ import annotations |
There was a problem hiding this comment.
Both black and ruff format it with the extra new line. Other modules also use this style:
cpython/Tools/build/deepfreeze.py
Line 9 in 715647a
So, I prefer to keep this as-is.
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 12, 2025
…nsion_modules` with mypy (pythonGH-137546) (cherry picked from commit 68a61b0) Co-authored-by: sobolevn <mail@sobolevn.me>
|
Sorry, @sobolevn, I could not cleanly backport this to |
|
GH-137679 is a backport of this pull request to the 3.14 branch. |
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Aug 12, 2025
…ck_extension_modules` with mypy (pythonGH-137546) (cherry picked from commit 68a61b0) Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Aug 12, 2025
…ck_extension_modules` with mypy (pythonGH-137546) (cherry picked from commit 68a61b0) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-137691 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.