gh-73487: Convert `_decimal` to use Argument Clinic (part 1) #137606

skirpichev · 2025-08-10T08:09:15Z

Issue: decimal: Use FASTCALL and/or Argument Clinic #73487

AA-Turner · 2025-08-10T17:26:09Z

Is the help(decimal) output identical before and after the PR?

I appreciate suggestion on how to make it easier to review.

It looks worse than it actually is, only ~400 lines diff in _decimal.c and ~190 lines of docstring-only changes in _decimal/docstrings.h. You could maybe split up the Decimal methods into a few groups to reduce the size of the PR, but no obvious such groupings spring to mind.

skirpichev · 2025-08-10T21:03:23Z

It looks worse than it actually is

As I said, it's more or less a mechanical change. No changes in signatures, docstrings are copied from docstrings.h (though, AC enforces to have PEP summary line, most decimal docstrings don't follow this - that changed). There should be a minor speedup from using METH_FASTCALL (see issue thread for examples, I'll do benchmarks later, maybe add news). I'm planning to use also METH_METHOD where possible, but in a separate patch.

no obvious such groupings spring to mind.

Different types, then method functions? I don't see how to make such split uniform.

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Modules/_decimal/_decimal.c

AA-Turner · 2025-08-11T02:01:53Z

Do you think it's now too hard to review?

Yes. I'm happy to look at the changes, just in a future PR instead of this one.

This reverts commit 354d8db.

AA-Turner · 2025-08-12T20:22:38Z

I would appreciate if #137624 can be merged first.

Now merged.

Serhiy also suggested (in #137685 (comment)) that AC conversions don't need NEWS entries, perhaps remove from this PR?

A

AA-Turner · 2025-08-12T21:19:03Z

Error in file 'Modules/_decimal/_decimal.c' on line 4616:
Warning:
Docstring lines for '_decimal.Decimal.to_integral_value' are too long!
Lines should be no longer than 72 characters.

Warning:
Docstring lines for '_decimal.Decimal.to_integral' are too long!
Lines should be no longer than 72 characters.

Warning:
Docstring lines for '_decimal.Decimal.to_integral_exact' are too long!
Lines should be no longer than 72 characters.

Summary line for '_decimal.Decimal.adjusted' is too long!
The summary line must be no longer than 72 characters.

This reverts commit 98b0e38.

skirpichev · 2025-08-13T02:42:22Z

Now merged.

Thanks, I fixed errors. BTW, tool should display them all.

Serhiy also suggested (in #137685 (comment)) that AC conversions don't need NEWS entries, perhaps remove from this PR?

Removed. I fine with this, though PR affects performance and - thus - has user-visible changes.

serhiy-storchaka · 2025-08-13T06:44:52Z

If this affects performance, you can mention methods that have become significantly faster.

serhiy-storchaka · 2025-08-13T06:48:05Z

Modules/_decimal/_decimal.c

+/*[clinic input]
+_decimal.Decimal.to_integral_value
+
+    self as dec: self


Why not rename dec to self?

Initially I did this, see reversion per reviewer request: 8b757da

I think that in long term it is better to change few more lines, but get rid of the self converter unless it is absolutely necessary (if we need a behavior different from default). But this is just nitpicks.

skirpichev · 2025-08-13T07:13:41Z

If this affects performance, you can mention methods that have become significantly faster.

It's a long list, every function that previously used METH_VARARGS is affected. I can restore news again, does it make sense?

serhiy-storchaka · 2025-08-13T07:29:29Z

I can restore news again, does it make sense?

If it does not mention Argument Clinic and other implementation details.

serhiy-storchaka

Technically, LGTM.

But since there were objections to this conversion from the author and a former developer, we need approval from several core developers who have worked on the decimal module for many years.

serhiy-storchaka · 2025-08-13T07:32:16Z

Modules/_decimal/_decimal.c

+/*[clinic input]
+_decimal.Decimal.to_integral_value
+
+    self as dec: self


I think that in long term it is better to change few more lines, but get rid of the self converter unless it is absolutely necessary (if we need a behavior different from default). But this is just nitpicks.

This reverts commit 8b757da.

skirpichev · 2025-08-13T07:57:46Z

Ok, I asked @vstinner and @picnixz for review.

Raymond removed request for review, I hope this doesn't mean he is -1 on this.

vstinner

LGTM. I like moving docstrings closer to function implementation, it helps to keep both consistent and up to date! The code is also easier to read. Hopefully, it may be even faster ;-)

picnixz

Same opinion as Victor.

vstinner · 2025-08-13T12:42:23Z

Merged. Thank you!

skirpichev · 2025-08-13T13:15:17Z

Thanks for reviews!

bedevere-bot · 2025-08-13T14:02:21Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 Refleaks 3.x (tier-3) has failed when building commit 70730ad.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/75/builds/3167) and take a look at the build logs.
Check if the failure is related to this commit (70730ad) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/75/builds/3167

Failed tests:

test_os
test_ssl
test.test_multiprocessing_fork.test_processes
test_external_inspection

Failed subtests:

test_get_server_certificate_timeout - test.test_ssl.SimpleBackgroundTests.test_get_server_certificate_timeout
test_timerfd_ns_select - test.test_os.TimerfdTests.test_timerfd_ns_select
test_connection - test.test_multiprocessing_fork.test_processes.WithProcessesTestConnection.test_connection
test_only_active_thread - test.test_external_inspection.TestGetStackTrace.test_only_active_thread

Test leaking resources:

test_ssl: memory blocks

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2094, in test_get_server_certificate_timeout
    with self.assertRaises(socket.timeout):
         ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
AssertionError: TimeoutError not raised


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2397, in run
    msg = self.read()
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2374, in read
    return self.sslconn.read()
           ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1148, in read
    return self._sslobj.read(len)
           ~~~~~~~~~~~~~~~~~^^^^^
 ssl.SSLError: [SSL: PEER_DID_NOT_RETURN_A_CERTIFICATE] peer did not return a certificate (_ssl.c:2942)
TLS: (<ssl.SSLSocket fd=5, family=2, type=1, proto=0, laddr=('127.0.0.1', 45158), raddr=('127.0.0.1', 44225)>, 'read', <TLSVersion.TLSv1_3: 772>, <_TLSContentType.ALERT: 21>, <_TLSAlertType.CERTIFICATE_REQUIRED: 116>, b'\x02t')
 connection timeout TimeoutError('timed out')
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1108)
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 3611, in test_connection
    self.assertEqual(poll(TIMEOUT1), True)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False != True


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: NO_SUITABLE_KEY_SHARE] no suitable key share (_ssl.c:1108)
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: SSLV3_ALERT_BAD_CERTIFICATE] sslv3 alert bad certificate (_ssl.c:1108)
 connection timeout TimeoutError('timed out')
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: SSLV3_ALERT_BAD_CERTIFICATE] sslv3 alert bad certificate (_ssl.c:1108)
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: NO_SUITABLE_KEY_SHARE] no suitable key share (_ssl.c:1108)
 connection timeout TimeoutError('timed out')
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_os.py", line 4613, in test_timerfd_ns_select
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 4 != 1


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2397, in run
    msg = self.read()
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2374, in read
    return self.sslconn.read()
           ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1148, in read
    return self._sslobj.read(len)
           ~~~~~~~~~~~~~~~~~^^^^^
 ssl.SSLError: [SSL: PEER_DID_NOT_RETURN_A_CERTIFICATE] peer did not return a certificate (_ssl.c:2942)
TLS: (<ssl.SSLSocket fd=5, family=2, type=1, proto=0, laddr=('127.0.0.1', 36762)>, 'read', <TLSVersion.TLSv1_3: 772>, <_TLSContentType.ALERT: 21>, <_TLSAlertType.CERTIFICATE_REQUIRED: 116>, b'\x02t')
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1108)
 connection timeout TimeoutError('timed out')
 server:  new connection from ('127.0.0.1', 51212)
 server: connection cipher is now ('ECDHE-PSK-CHACHA20-POLY1305', 'TLSv1.2', 256)
 server:  new connection from ('127.0.0.1', 49074)
 server: connection cipher is now ('ECDHE-PSK-CHACHA20-POLY1305', 'TLSv1.2', 256)
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:1108)
 server:  new connection from ('127.0.0.1', 44742)
 server: connection cipher is now ('TLS_AES_256_GCM_SHA384', 'TLSv1.3', 256)
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/multiprocessing/process.py", line 320, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 518, in _sleep_some_event
    time.sleep(100)
    ~~~~~~~~~~^^^^^
KeyboardInterrupt
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:1108)
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_external_inspection.py", line 1246, in test_only_active_thread
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        len(gil_traces), 1, "Should have exactly one GIL holder"
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 0 != 1 : Should have exactly one GIL holder


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:1108)
 server:  new connection from ('127.0.0.1', 52650)
 server: connection cipher is now ('TLS_AES_256_GCM_SHA384', 'TLSv1.3', 256)
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:1108)
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: SSLV3_ALERT_BAD_CERTIFICATE] sslv3 alert bad certificate (_ssl.c:1108)
 connection timeout TimeoutError('timed out')
 connection timeout TimeoutError('timed out')
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: NO_SHARED_CIPHER] no shared cipher (_ssl.c:1108)
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:1108)
 connection timeout TimeoutError('timed out')
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLError: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:1108)
 server:  new connection from ('127.0.0.1', 56386)
 server: connection cipher is now ('ECDHE-PSK-CHACHA20-POLY1305', 'TLSv1.2', 256)
 server:  new connection from ('127.0.0.1', 44776)
 server: connection cipher is now ('ECDHE-PSK-CHACHA20-POLY1305', 'TLSv1.2', 256)
k


Traceback (most recent call last):
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/test/test_ssl.py", line 2313, in wrap_conn
    self.sslconn = self.server.context.wrap_socket(
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        self.sock, server_side=True)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 455, in wrap_socket
    return self.sslsocket_class._create(
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
        sock=sock,
        ^^^^^^^^^^
    ...<5 lines>...
        session=session
        ^^^^^^^^^^^^^^^
    )
    ^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1084, in _create
    self.do_handshake()
    ~~~~~~~~~~~~~~~~~^^
   File "/home/buildbot/buildarea/3.x.cstratak-rhel8-s390x.refleak/build/Lib/ssl.py", line 1399, in do_handshake
    self._sslobj.do_handshake()
    ~~~~~~~~~~~~~~~~~~~~~~~~~^^
 ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1108)

bedevere-app bot mentioned this pull request Aug 10, 2025

decimal: Use FASTCALL and/or Argument Clinic #73487

Open

skirpichev added the skip news label Aug 10, 2025

skirpichev changed the title ~~gh-73487: convert the decimal module to use AC~~ gh-73487: convert the _decimal module to use AC Aug 10, 2025

pythongh-73487: convert the _decimal module to use AC

439380e

skirpichev force-pushed the ac-decimal/73487 branch from 812708a to 439380e Compare August 10, 2025 08:40

This comment has been minimized.

Sign in to view

skirpichev added 2 commits August 10, 2025 16:21

+1

ada9e7e

+1

22eb776

Reduce docstring diff

b161565

This comment was marked as outdated.

Sign in to view

bedevere-app bot added the awaiting merge label Aug 10, 2025

AA-Turner changed the title ~~gh-73487: convert the _decimal module to use AC~~ gh-73487: Convert _decimal to use Argument Clinic Aug 10, 2025

skirpichev added the DO-NOT-MERGE label Aug 10, 2025

skirpichev and others added 2 commits August 11, 2025 04:09

Apply suggestions from code review

2c53b48

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

+1

354d8db

This comment was marked as resolved.

Sign in to view

AA-Turner reviewed Aug 11, 2025

View reviewed changes

Modules/_decimal/_decimal.c Outdated Show resolved Hide resolved

address review: move to_integral_value around

d78a97f

This comment was marked as resolved.

Sign in to view

Revert "+1"

81cba59

This reverts commit 354d8db.

skirpichev requested a review from AA-Turner August 11, 2025 02:08

This comment was marked as resolved.

Sign in to view

skirpichev changed the title ~~gh-73487: Convert _decimal to use Argument Clinic~~ gh-73487: Convert _decimal to use Argument Clinic (part 1) Aug 11, 2025

skirpichev added 2 commits August 11, 2025 05:52

address review: rename some self

8b757da

address review: remove old doc_to_integral_value

306980a

rhettinger removed their request for review August 12, 2025 16:31

Merge branch 'main' into ac-decimal/73487

21472b0

skirpichev added 3 commits August 13, 2025 05:39

Merge branch 'master' into ac-decimal/73487

60e8d44

adjust docstrings after python#137624

a4f7f0c

Revert "add news"

7ca03bd

This reverts commit 98b0e38.

skirpichev added the skip news label Aug 13, 2025

serhiy-storchaka reviewed Aug 13, 2025

View reviewed changes

serhiy-storchaka approved these changes Aug 13, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Aug 13, 2025

skirpichev added 2 commits August 13, 2025 10:50

address review: re-add news (don't mention AC now) :)

ab62391

Revert "address review: rename some self"

ec221f1

This reverts commit 8b757da.

skirpichev requested review from vstinner and picnixz August 13, 2025 07:55

skirpichev removed the skip news label Aug 13, 2025

vstinner approved these changes Aug 13, 2025

View reviewed changes

picnixz approved these changes Aug 13, 2025

View reviewed changes

vstinner merged commit 70730ad into python:main Aug 13, 2025
46 checks passed

bedevere-app bot removed the awaiting merge label Aug 13, 2025

skirpichev deleted the ac-decimal/73487 branch August 13, 2025 13:10

Uh oh!

gh-73487: Convert _decimal to use Argument Clinic (part 1) #137606

gh-73487: Convert _decimal to use Argument Clinic (part 1) #137606

Uh oh!

Conversation

skirpichev commented Aug 10, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

AA-Turner commented Aug 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skirpichev commented Aug 10, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

AA-Turner commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

AA-Turner commented Aug 12, 2025

Uh oh!

AA-Turner commented Aug 12, 2025

Uh oh!

skirpichev commented Aug 13, 2025

Uh oh!

serhiy-storchaka commented Aug 13, 2025

Uh oh!

serhiy-storchaka Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

skirpichev Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

skirpichev Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

skirpichev commented Aug 13, 2025

Uh oh!

serhiy-storchaka commented Aug 13, 2025

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Aug 13, 2025

Choose a reason for hiding this comment

Uh oh!

skirpichev commented Aug 13, 2025

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vstinner commented Aug 13, 2025

Uh oh!

skirpichev commented Aug 13, 2025

Uh oh!

bedevere-bot commented Aug 13, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

gh-73487: Convert `_decimal` to use Argument Clinic (part 1) #137606

gh-73487: Convert `_decimal` to use Argument Clinic (part 1) #137606

skirpichev commented Aug 10, 2025 •

edited by bedevere-app bot

Loading

AA-Turner commented Aug 10, 2025 •

edited

Loading

AA-Turner commented Aug 11, 2025 •

edited

Loading