Skip to content

GH-137630: Convert _interpqueues to use Argument Clinic #137685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

GH-137630: Convert _interpqueues to use Argument Clinic #137685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4ac7307
Convert _interpqueues.create()
AA-Turner Aug 12, 2025
b28e303
Convert _interpqueues.destroy()
AA-Turner Aug 12, 2025
616ca56
Convert _interpqueues.list_all()
AA-Turner Aug 12, 2025
4432216
Convert _interpqueues.put()
AA-Turner Aug 12, 2025
214ab30
Convert _interpqueues.get()
AA-Turner Aug 12, 2025
cdafcd8
Convert _interpqueues.bind()
AA-Turner Aug 12, 2025
ae9ee89
Convert _interpqueues.release()
AA-Turner Aug 12, 2025
3b8bf48
Convert _interpqueues.get_maxsize()
AA-Turner Aug 12, 2025
822b206
Convert _interpqueues.get_queue_defaults()
AA-Turner Aug 12, 2025
0a4d8f9
Convert _interpqueues.is_full()
AA-Turner Aug 12, 2025
ca68aa7
Convert _interpqueues.get_count()
AA-Turner Aug 12, 2025
2fd1f9a
Convert _interpqueues._register_heap_types()
AA-Turner Aug 12, 2025
3cd5b3c
Improve qidarg_converter
AA-Turner Aug 12, 2025
07e8d7a
Fix "implicit declaration of function ‘qidarg_converter’"
AA-Turner Aug 12, 2025
b426a9e
Blurb
AA-Turner Aug 12, 2025
000e659
make regen-all
AA-Turner Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Include/internal/pycore_global_objects_fini_generated.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions Include/internal/pycore_global_strings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(eager_start)
STRUCT_FOR_ID(effective_ids)
STRUCT_FOR_ID(element_factory)
STRUCT_FOR_ID(emptyerror)
STRUCT_FOR_ID(encode)
STRUCT_FOR_ID(encoding)
STRUCT_FOR_ID(end)
Expand All @@ -440,6 +441,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(extra_tokens)
STRUCT_FOR_ID(facility)
STRUCT_FOR_ID(factory)
STRUCT_FOR_ID(fallback)
STRUCT_FOR_ID(false)
STRUCT_FOR_ID(family)
STRUCT_FOR_ID(fanout)
Expand Down Expand Up @@ -471,6 +473,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(fromtimestamp)
STRUCT_FOR_ID(fromutc)
STRUCT_FOR_ID(fset)
STRUCT_FOR_ID(fullerror)
STRUCT_FOR_ID(func)
STRUCT_FOR_ID(future)
STRUCT_FOR_ID(generation)
Expand Down Expand Up @@ -582,6 +585,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(maxevents)
STRUCT_FOR_ID(maxlen)
STRUCT_FOR_ID(maxmem)
STRUCT_FOR_ID(maxsize)
STRUCT_FOR_ID(maxsplit)
STRUCT_FOR_ID(maxvalue)
STRUCT_FOR_ID(memLevel)
Expand Down Expand Up @@ -676,7 +680,9 @@ struct _Py_global_strings {
STRUCT_FOR_ID(protocol)
STRUCT_FOR_ID(ps1)
STRUCT_FOR_ID(ps2)
STRUCT_FOR_ID(qid)
STRUCT_FOR_ID(query)
STRUCT_FOR_ID(queuetype)
STRUCT_FOR_ID(quotetabs)
STRUCT_FOR_ID(raw)
STRUCT_FOR_ID(read)
Expand Down Expand Up @@ -796,6 +802,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(tzinfo)
STRUCT_FOR_ID(tzname)
STRUCT_FOR_ID(uid)
STRUCT_FOR_ID(unboundop)
STRUCT_FOR_ID(unlink)
STRUCT_FOR_ID(unraisablehook)
STRUCT_FOR_ID(updates)
Expand Down
7 changes: 7 additions & 0 deletions Include/internal/pycore_runtime_init_generated.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 28 additions & 0 deletions Include/internal/pycore_unicodeobject_generated.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-08-12-19-10-25.gh-issue-137630.n6CkjJ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The :mod:`!_interpqueues` module now uses Argument Clinic to parse arguments.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually do not add NEWS files for conversions to Argument Clinic. Argument Clinic is an implementation detail.

Patch by Adam Turner.
Loading
Loading