Skip to content

gh-137706: make typing._is_unpacked_typevartuple check for True instead of truthy #137712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-137706: make typing._is_unpacked_typevartuple check for True instead of truthy #137712

wants to merge 1 commit into from
+16 −1

Conversation

DavidCEllis
Copy link
Contributor

@DavidCEllis DavidCEllis commented Aug 13, 2025 •
edited by bedevere-app bot
Loading

This resolves #137706 making Annotated[undefined, ''] partially resolvable under Format.FORWARDREF

I hope I put the additional test in a reasonable place. It's a large file!

@DavidCEllis
Check for True instead of truthy for TypeVarTuple unpacking
c472bce 
truthy output was interpreting annotationlib _Stringifier instances as unpacked TypeVarTuples
@bedevere-app bedevere-app bot mentioned this pull request Aug 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotated with forward references does not partially evaluate
1 participant
@DavidCEllis