Skip to content

gh-137716: Fix double period in AttributeError message for invalid mock assertions #137717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2025
Merged

gh-137716: Fix double period in AttributeError message for invalid mock assertions #137717

merged 3 commits into from
Aug 14, 2025
+2 −1

Conversation

rohanwinsor
Copy link
Contributor

@rohanwinsor rohanwinsor commented Aug 13, 2025 •
edited by bedevere-app bot
Loading

@rohanwinsor rohanwinsor requested a review from cjw296 as a code owner August 13, 2025 16:52
@python-cla-bot
Copy link

python-cla-bot bot commented Aug 13, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Aug 13, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@rohanwinsor rohanwinsor mentioned this pull request Aug 13, 2025
Open
@StanFromIreland StanFromIreland changed the title gh- 137716: Fix double period in AttributeError message for invalid mock assertions gh-137716: Fix double period in AttributeError message for invalid mock assertions Aug 13, 2025
StanFromIreland
StanFromIreland reviewed Aug 13, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the wrong place for this fix. This should be fixed in traceback IMO, it should not add another period if one exists.

@rohanwinsor
Copy link
Contributor Author

So here, we should check for self._str.rstrip().endsiwth(".") and add dot based on that.

But since dot is being added by default in the traceback, as well as all other attribute errors raised don't have dot in the end of them. Doesn't it make sense to remove it in mock ?

hauntsaninja
hauntsaninja approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm fine with this. We can pursue the traceback change independently, but most AttributeError do not end with a period

@hauntsaninja hauntsaninja enabled auto-merge (squash) August 14, 2025 21:20
@hauntsaninja hauntsaninja merged commit 8665769 into python:main Aug 14, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

@cjw296 cjw296 Awaiting requested review from cjw296 cjw296 is a code owner

@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohanwinsor @hauntsaninja @StanFromIreland