Skip to content

gh-132339: Add support for OpenSSL 3.5 #137720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 14, 2025
Merged

gh-132339: Add support for OpenSSL 3.5 #137720

merged 8 commits into from
Aug 14, 2025

Conversation

zware
Copy link
Member

@zware zware commented Aug 13, 2025

Includes _ssl_data*.h update, as well as updating other versions in CI.

@zware zware marked this pull request as ready for review August 13, 2025 17:43
@gpshead gpshead added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 14, 2025
@zware zware merged commit 7a703c8 into python:main Aug 14, 2025
87 of 89 checks passed
@zware zware deleted the ssl35 branch August 14, 2025 04:18
@miss-islington-app
Copy link

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @zware, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7a703c8f1942c8bd07943458962f6e59d2892757 3.14

@miss-islington-app
Copy link

Sorry, @zware, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7a703c8f1942c8bd07943458962f6e59d2892757 3.13

zware added a commit to zware/cpython that referenced this pull request Aug 14, 2025
* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)

* Demote OpenSSL 3.1 to "old", remove it from CI

* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults

* Add OpenSSL 3.5.2 to CI configuration and multissltests default list

* Fix a typo in the argument parser description of multissltests.py
(cherry picked from commit 7a703c8)

Co-authored-by: Zachary Ware <zach@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Aug 14, 2025

GH-137747 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 14, 2025
@zware
Copy link
Member Author

zware commented Aug 14, 2025

The 3.13 backport is complicated by the fact that 3.4 support was not backported there; presumably we want to do that first? I think we do want to make sure 3.5 at least works back to 3.13 (maybe even further?), but how critical is the _ssl_data*.h update for that?

cc: @encukou from GH-127330 (3.4) and @picnixz from GH-131618 (3.4.1)

hugovk pushed a commit that referenced this pull request Aug 14, 2025
* Add OpenSSL 3.5.2 definitions to Modules/_ssl_data_35.h (moved from Modules/_ssl_data_34.h)

* Demote OpenSSL 3.1 to "old", remove it from CI

* Update all OpenSSL versions to latest patchlevel in CI config and multissltests defaults

* Add OpenSSL 3.5.2 to CI configuration and multissltests default list

* Fix a typo in the argument parser description of multissltests.py
(cherry picked from commit 7a703c8)
@bedevere-bot

This comment was marked as off-topic.

@encukou
Copy link
Member

encukou commented Aug 14, 2025

The ssl_data*.h is only used for error messages.

@bedevere-bot

This comment was marked as off-topic.

@bedevere-bot

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport to 3.13 bugs and security fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants