Skip to content

gh-137725: Convert faulthandler to Argument Clinic #137726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+956 −154
Open

gh-137725: Convert faulthandler to Argument Clinic #137726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ccb1f2a
gh-137725: Convert faulthandler to Argument Clinic
vstinner Aug 13, 2025
068b4e8
Fix Windows build
vstinner Aug 13, 2025
dd3137a
Update Modules/faulthandler.c
vstinner Aug 14, 2025
72c5342
Fix constants on Windows
vstinner Aug 14, 2025
f52d2d4
enable: add c_stack parameter
vstinner Aug 14, 2025
1f5a8e4
Add test_enable_without_c_stack()
vstinner Aug 14, 2025
8a2737c
is True => is true
vstinner Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Include/internal/pycore_global_objects_fini_generated.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions Include/internal/pycore_global_strings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(c_exception)
STRUCT_FOR_ID(c_parameter_type)
STRUCT_FOR_ID(c_return)
STRUCT_FOR_ID(c_stack)
STRUCT_FOR_ID(cached_datetime_module)
STRUCT_FOR_ID(cached_statements)
STRUCT_FOR_ID(cadata)
Expand All @@ -340,6 +341,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(category)
STRUCT_FOR_ID(cb_type)
STRUCT_FOR_ID(certfile)
STRUCT_FOR_ID(chain)
STRUCT_FOR_ID(check_same_thread)
STRUCT_FOR_ID(clear)
STRUCT_FOR_ID(close)
Expand Down Expand Up @@ -434,6 +436,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(excepthook)
STRUCT_FOR_ID(exception)
STRUCT_FOR_ID(existing_file_name)
STRUCT_FOR_ID(exit)
STRUCT_FOR_ID(exp)
STRUCT_FOR_ID(expression)
STRUCT_FOR_ID(extend)
Expand Down Expand Up @@ -694,6 +697,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(rel_tol)
STRUCT_FOR_ID(release)
STRUCT_FOR_ID(reload)
STRUCT_FOR_ID(repeat)
STRUCT_FOR_ID(repl)
STRUCT_FOR_ID(replace)
STRUCT_FOR_ID(reqrefs)
Expand Down Expand Up @@ -732,6 +736,7 @@ struct _Py_global_strings {
STRUCT_FOR_ID(shared)
STRUCT_FOR_ID(show_cmd)
STRUCT_FOR_ID(signed)
STRUCT_FOR_ID(signum)
STRUCT_FOR_ID(size)
STRUCT_FOR_ID(sizehint)
STRUCT_FOR_ID(skip_file_prefixes)
Expand Down
5 changes: 5 additions & 0 deletions Include/internal/pycore_runtime_init_generated.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions Include/internal/pycore_unicodeobject_generated.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions Lib/test/test_faulthandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,17 @@ def test_enable_single_thread(self):
'Segmentation fault',
all_threads=False)

@skip_segfault_on_android
def test_enable_without_c_stack(self):
self.check_fatal_error("""
import faulthandler
faulthandler.enable(c_stack=False)
faulthandler._sigsegv()
""",
3,
'Segmentation fault',
c_stack=False)

@skip_segfault_on_android
def test_disable(self):
code = """
Expand Down
Loading
Loading