Skip to content

gh-125854: Improve error messages for invalid category in the warnings module #137750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

gh-125854: Improve error messages for invalid category in the warnings module #137750

merged 1 commit into from
Aug 14, 2025
+31 −38

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 14, 2025 •
edited
Loading

  • Include the type name if category is a type, but not a Warning subtype, instead of just 'type'.
  • Validate category in simplefilter().

@bedevere-app bedevere-app bot mentioned this pull request Aug 14, 2025
Closed
@serhiy-storchaka serhiy-storchaka force-pushed the warnings-invalid-category branch 2 times, most recently from 75ac565 to a25815d Compare August 14, 2025 08:02
@serhiy-storchaka
pythongh-125854: Improve error messages for invalid category in warni…
ad15208 
…ngs.warn()

Include the type name if category is a type, but not a Warning
subtype, instead of just 'type'.
@serhiy-storchaka serhiy-storchaka force-pushed the warnings-invalid-category branch from a25815d to ad15208 Compare August 14, 2025 08:27
@serhiy-storchaka
Copy link
Member Author

I initially added more details in the error message filterwarning() and added the same check in simplefilter(), but then removed them. simplefilter() supports not only subclasses of Warning (although this is not documented), and there are plans to allow this in filterwarning().

ncoghlan
ncoghlan approved these changes Aug 14, 2025
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@serhiy-storchaka serhiy-storchaka merged commit c47ffbf into python:main Aug 14, 2025
48 checks passed
@serhiy-storchaka serhiy-storchaka deleted the warnings-invalid-category branch August 14, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @ncoghlan