gh-137242: Build Android artifacts in a reusable workflow #137768
Conversation
This is a follow-up for python#137186 aiming to make the initially added automation live in its own "module" rather than the top-level workflow and make it possible to reuse it externally.
|
I think this can go under the same issue, #137242? |
|
Thanks; I'm on holiday for the next few days, but I'll look at this when I get back. |
|
So - I can see how this change works; I guess the part I'm not understanding is why it's a net improvement. Adding this reusable workflow adds almost 100 lines of (moderately complex) GitHub Actions configuration, so that we can re-use the workflow... in exactly 2 places. In one of those places (CPython's repo), exactly 1 line of code is saved by this refactor; in release-tools, we save 9 lines. And the duplicated code that is being replaced isn't especially complex - it's "checkout repository", "call single script", "save artefacts" - all very common (and reasonably well understood) actions; and it's being replaced by a workflow configuration that isn't exactly complex, but at the very least has it's own learning curve. In a world where the Is there some other use case that I'm missing? Some other benefit of being a reusable workflow? |
This is a follow-up for #137186 aiming to make the initially added automation live in its own "module" rather than the top-level workflow and make it possible to reuse it externally.
It will also enable a companion change externally: python/release-tools#270.