Skip to content

gh-133171: Re-enable JUMP_BACKWARD to free-threading build #137800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Aug 15, 2025

@corona10
Copy link
Member Author

@savannahostrowski @diegorusso @Fidget-Spinner @brandtbucher

To the JIT team — I’m not sure who’s currently working on this, but it might be a good starting point to add JIT support. My next goal will be to make the tier-two instructions thread-safe.

@Fidget-Spinner
Copy link
Member

I think we should start by running the tests in CI for JIT+FT current build and see what passes/fails before doing this

@corona10
Copy link
Member Author

corona10 commented Aug 15, 2025

I think we should start by running the tests in CI for JIT+FT current build and see what passes/fails before doing this

We disabled FT + JIT build from #133179 do you think that we have to listing the current status?
Could we separate this task into making the tier 2 interpreter thread-safe (with optimizer disabled) and the optimizer thread-safe?

@Fidget-Spinner
Copy link
Member

Could we separate this task into making the tier 2 interpreter thread-safe (with optimizer disabled) and the optimizer thread-safe?

This makes sense but actually the default build's JIT can't even run with the optimizer turned off! There's some segfaults when we turn off the optimizer lol.

@corona10
Copy link
Member Author

This makes sense but actually the default build's JIT can't even run with the optimizer turned off! There's some segfaults when we turn off the optimizer lol.

How can I trigger this?

@Fidget-Spinner
Copy link
Member

This makes sense but actually the default build's JIT can't even run with the optimizer turned off! There's some segfaults when we turn off the optimizer lol.

How can I trigger this?

Run the test suite with PYTHON_UOPS_OPTIMIZE=0 env var.

@corona10
Copy link
Member Author

Run the test suite with PYTHON_UOPS_OPTIMIZE=0 env var.

Just for the record at default build:
PYTHON_UOPS_OPTIMIZE=0 ./python.exe -m test -j8

39 tests failed:
    test.test_asyncio.test_pep492
    test.test_multiprocessing_forkserver.test_processes
    test.test_multiprocessing_spawn.test_processes test_array test_bdb
    test_buffer test_code test_codecmaps_cn test_codecmaps_hk
    test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw
    test_collections test_complex test_datetime test_embed test_float
    test_htmlparser test_idle test_import test_json test_long
    test_math test_patma test_peepholer test_pickle test_pow
    test_random test_scope test_slice test_ssl test_struct
    test_sys_settrace test_tarfile test_threading test_time test_trace
    test_zipimport_support test_zoneinfo

@corona10

This comment has been minimized.

@corona10
Copy link
Member Author

Ah never mind, it need to be transformed tier 2 code first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants