gh-96863: Fix subprocess.Popen.wait to raise ProcessLookupError for external waits #137804
+49
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
corona10
reviewed
Aug 15, 2025
| proc.wait() | ||
| try: | ||
| proc.wait() | ||
| except ProcessLookupError: |
There was a problem hiding this comment.
Would you like to use https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaises if it is always happened?
There was a problem hiding this comment.
Thanks! I’ll use assertRaises here.
There was a problem hiding this comment.
It seems it’s not always raised, so I’ll revert to using a try–except block on cb8d874.
corona10
reviewed
Aug 15, 2025
| sts = 0 | ||
| return (pid, sts) | ||
|
|
||
| raise ProcessLookupError(f'Process {self.pid} is already waited on externally') |
There was a problem hiding this comment.
@gpshead I think that we should specify status code rather than raise exception because it will change current behavior. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for the Issue: #96863