Skip to content

gh-127859: Fixed documentation for call_later and call_at regarding early wakeup. #137859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025

Conversation

bharel
Copy link
Contributor

@bharel bharel commented Aug 16, 2025

Copy link
Contributor

@sharktide sharktide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The news looks good to me, but maybe we can merge the two notes into one or better yet remove the note tags altogether. But I’m not sure about this either ways it looks all right

@bharel
Copy link
Contributor Author

bharel commented Aug 17, 2025

maybe we can merge the two notes into one or better yet remove the note tags altogether

I thought about it. When I've put it at the end of the section it wasn't visible enough. The duplication here helps readability. The note is a little too visible on one hand, but it is an "unrelated note" on the other hand, which is why I sectioned it like so.

@bharel bharel requested a review from kumaraditya303 August 17, 2025 15:35
Copy link
Contributor

@sharktide sharktide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kumaraditya303 kumaraditya303 merged commit 92be979 into python:main Aug 18, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Aug 18, 2025
@kumaraditya303 kumaraditya303 added topic-asyncio needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 18, 2025
@miss-islington-app
Copy link

Thanks @bharel for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @bharel for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2025
…arly wakeup in asyncio (pythonGH-137859)

(cherry picked from commit 92be979)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 18, 2025
…arly wakeup in asyncio (pythonGH-137859)

(cherry picked from commit 92be979)

Co-authored-by: Bar Harel <bzvi7919@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 18, 2025

GH-137907 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 18, 2025
@bedevere-app
Copy link

bedevere-app bot commented Aug 18, 2025

GH-137908 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-asyncio
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants