gh-77566: Clarify setdefault() behavior for dbm objects #137911
Closed
+33
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we could use |
| @@ -95,6 +95,10 @@ The object returned by :func:`~dbm.open` supports the same basic functionality a | |||
| deleted, and the :keyword:`in` operator and the :meth:`!keys` method are | |||
| available, as well as :meth:`!get` and :meth:`!setdefault` methods. | |||
|
|
|||
| .. note:: | |||
| Unlike the standard :class:`dict` type, the :meth:`dict.setdefault` method | |||
There was a problem hiding this comment.
This is self-contradictory. You need to refer to :meth:`!setdefault` instead of :meth:`dict.setdefault` .
Also, I suggest to refer to :term:`mapping` instead of :class:`dict` above.
| @@ -204,6 +208,14 @@ or any other SQLite browser, including the SQLite CLI. | |||
|
|
|||
| .. versionadded:: next | |||
|
|
|||
| .. method:: sqlite3.setdefault(key, default) | |||
There was a problem hiding this comment.
No other methods are documented here, except reorganize(). Even close() is barely mentioned.
|
Many other documentation changes are needed. So I created other PR for them, and the |
|
See #137919. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--137911.org.readthedocs.build/