Skip to content

Use consistent tab titles #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

Use consistent tab titles #1634

merged 1 commit into from
Aug 14, 2025

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 14, 2025

Follow on from #1632.

We already have tabs on https://devguide.python.org/getting-started/setup-building/ with this pattern:

image

I suggest we follow the same pattern and change this:

image

To this:

image

📚 Documentation preview 📚: https://cpython-devguide--1634.org.readthedocs.build/

@hugovk hugovk requested a review from brettcannon August 14, 2025 13:09
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on changing and newer to just +.
From reading the documentation it seems that any Python can be used to launch the command that builds both the build CPython and the WASI CPython, so removing the C from CPython seems ok to me as well, but I'll leave the final decision to @brettcannon.

@hugovk
Copy link
Member Author

hugovk commented Aug 14, 2025

Yeah, this is the "Python Developer’s Guide" but it's strictly the "CPython Developer’s Guide" and won't help you much for PyPy or another implementation.

@brettcannon
Copy link
Member

From reading the documentation it seems that any Python can be used to launch the command that builds both the build CPython and the WASI CPython

Correct, although what you do based on the CPython checkout you're working with is different (hence why I went with "CPython").

@hugovk hugovk merged commit 298e76b into python:main Aug 14, 2025
5 checks passed
@hugovk hugovk deleted the consistent-tabs branch August 14, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants