[mypyc] Free coroutine after await encounters StopIteration #19231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the awaited generator could stay alive until the generator
that performed the await was freed, delaying object reclamation. The
refcount analysis doesn't understand registers spilled to the
environment, so we need to manually clear the value.
Consider code like this:
```
async def foo() -> None:
await bar()
await zar()
```
Previously, the `bar()` generator was only freed at end of `foo()`. Now
we release it before `await zar()`, as expected.
svalentin
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the awaited coroutine could stay alive until the coroutine that performed the await was freed, delaying object reclamation. The reference counting analysis doesn't understand registers spilled to the environment, so we need to manually clear the value.
Consider code like this:
Previously, the
bar()coroutine was only freed at end offoo(). Now we release it beforeawait zar(), as expected.