[mypyc] feat: extend stararg fastpath from #19629 with star2 fastpath #19630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…mypy into star2arg-fastpath
for more information, see https://pre-commit.ci
BobTheBuidler
commented
Aug 13, 2025
| r9 = PyObject_Call(r3, r7, r8) | ||
| r10 = unbox(tuple[int, int, int], r9) | ||
| return r10 | ||
| r4 = box(tuple[int, int, int], r0) |
There was a problem hiding this comment.
Should I also add handling for RTuple types? I don't see any reason to box this value into a python tuple only to then call PySequence_Tuple
|
Might be best to hold off on this one until #1956 is merged and we can ensure PyDict_Copy is safe Or we can use CPyDict_Copy here so we can merge it now and replace it with the fast path with 1956 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further extends the stararg fastpath PRs (#19623 , #19629) with fastpath logic for star2
All 3 PRs were kept separate in order to make them easier to review and to make the changes in the IR more obvious in a diff. I will rebase this PR once #19623 and #19629 are merged.
This full series of PRs is ready for review.