[mypyc] feat: new primitive for int.bit_length
#19673
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
|
||
| // int.bit_length() | ||
| CPyTagged CPyTagged_BitLength(CPyTagged self) { | ||
| PyObject *pyint = CPyTagged_StealAsObject(self); |
There was a problem hiding this comment.
do we need this PyLong_Check?
There was a problem hiding this comment.
No, it's always an instance of int.
for more information, see https://pre-commit.ci
|
|
||
| // int.bit_length() | ||
| CPyTagged CPyTagged_BitLength(CPyTagged self) { | ||
| PyObject *pyint = CPyTagged_StealAsObject(self); |
There was a problem hiding this comment.
No, it's always an instance of int.
| #if defined(__GNUC__) || defined(__clang__) | ||
| bits = (int)(CPY_BITS - CPY_CLZ(absval)); | ||
| #else | ||
| // Fallback to loop if no builtin |
There was a problem hiding this comment.
What about using _BitScanReverse[64] on MSVC (https://learn.microsoft.com/en-us/cpp/intrinsics/bitscanreverse-bitscanreverse64?view=msvc-170)?
There was a problem hiding this comment.
Interesting. No, I did not consider this but I didn't realize it was an option. Will need to look thru the docs and figure out the best way to integrate.
mypyc/test-data/run-integers.test
Outdated
| def bit_length(n: int) -> int: | ||
| return n.bit_length() | ||
| def test_bit_length() -> None: | ||
| assert bit_length(0) == 0 |
There was a problem hiding this comment.
Minor: This would be a bit more robust if you'd have say bit_length_python function that does return getattr(n, "bit_length")() and you can assert that bit_length(n) == bit_length_python(n).
There was a problem hiding this comment.
Well that's odd, I implemented the tests as you asked here but now we get segfaults on Python3.14
There was a problem hiding this comment.
Also on the 32-bit test runner
There was a problem hiding this comment.
okay... well after implementing your bitscan idea the issue has resolved itself on python3.14... somehow
This PR adds a new primitive for
int.bit_lengthand is already ready for review.