Force all deserialized objects to the oldest GC generation #19681
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized I did my measurements with fixed-format cache, but I guess the numbers will be similar for JSON cache. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
reviewed
Aug 18, 2025
| # a hack, but it gives huge performance wins for large third-party | ||
| # libraries, like torch. | ||
| gc.collect() | ||
| gc.disable() |
There was a problem hiding this comment.
Could we get here multiple times, if there are multiple dirty sub-DAGs? If yes, do you think it'll be a problem?
A quick workaround would be to do this only at most N times per run (possibly N=1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack, but it gives ~30% perf win for
mypy -c 'import torch'on a warm run. This should not increase memory consumption too much, since we shouldn't create any cyclic garbage during deserialization (we do create some cyclic references, likeTypeInfo->SymbolTable->Instance->TypeInfo, but those are genuine long-living objects).