PEP 793: Updates from discussion & implementation #4453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Jun 10, 2025
| @@ -26,6 +26,10 @@ To make this viable, we also specify new module slot types to replace | |||
|
|
|||
| We also add an API for defining modules from slots dynamically. | |||
|
|
|||
| The existing API (``PyInit_*``) is soft-deprecated. | |||
| (That is: it will continue to work without warnings, and it'll fe fully | |||
There was a problem hiding this comment.
Suggested change
| (That is: it will continue to work without warnings, and it'll fe fully | |
| (That is: it will continue to work without warnings, and it'll be fully |
| @@ -264,6 +289,10 @@ If specified, using a new ``Py_mod_token`` slot, the module token must: | |||
|
|
|||
| (Typically, it should point to a static constant.) | |||
|
|
|||
| When the address of a ``PyModuleDef`` is used as as a module's token, | |||
There was a problem hiding this comment.
Suggested change
| When the address of a ``PyModuleDef`` is used as as a module's token, | |
| When the address of a ``PyModuleDef`` is used as a module's token, |
Comment on lines
+431
to
+432
| whose definition changed. Module authors may avoid this by explicitly | ||
| explicitly setting a *def* as the *token*. |
There was a problem hiding this comment.
Suggested change
| whose definition changed. Module authors may avoid this by explicitly | |
| explicitly setting a *def* as the *token*. | |
| whose definition changed. Module authors may avoid this by explicitly | |
| setting a *def* as the *token*. |
| #. Scan your code for uses of ``PyType_GetModuleByDef``, and replace them by | ||
| ``PyType_GetModuleByToken``. | ||
| #. Optionally, scan your code for uses of ``PyType_GetModuleByDef``, | ||
| and replace them by ``PyType_GetModuleByToken``. |
There was a problem hiding this comment.
Suggested change
| and replace them by ``PyType_GetModuleByToken``. | |
| and replace them with ``PyType_GetModuleByToken``. |
| Later in this guide, you'll set the token to *be* the existing | ||
| ``PyModuleDef`` structure. | ||
|
|
||
| (You may skip this step if targetting Python versions that don't expose | ||
| ``PyType_GetModuleByToken``, since ``PyType_GetModuleByDef`` is | ||
| backwards-compatible. ) |
There was a problem hiding this comment.
Suggested change
| backwards-compatible. ) | |
| backwards-compatible.) |
|
|
||
| #. If the existing ``PyModuleDef`` struct is used *only* for ``Py_mod_token`` | ||
| and/or ``PyType_GetModuleByToken``, you may remove the ``Py_mod_token`` | ||
| line and replace ``&your_module_def`` by ``module_slots`` everywhere else. |
There was a problem hiding this comment.
Suggested change
| line and replace ``&your_module_def`` by ``module_slots`` everywhere else. | |
| line and replace ``&your_module_def`` with ``module_slots`` everywhere else. |
| Backwards compatibility shim | ||
| ---------------------------- | ||
|
|
||
| It is possible to write generic function that implements the “old” export |
There was a problem hiding this comment.
Suggested change
| It is possible to write generic function that implements the “old” export | |
| It is possible to write a generic function that implements the “old” export |
| - Any ``Py_mod_token`` must be set to ``&module_def_and_token``, defined here. | ||
|
|
||
| It also passes ``NULL`` as *spec* to the ``PyModExport`` export hook. | ||
| A proper implementation would pass ``None`` instead, . |
There was a problem hiding this comment.
Suggested change
| A proper implementation would pass ``None`` instead, . | |
| A proper implementation would pass ``None`` instead. |
| @@ -550,6 +653,7 @@ Possible Future Directions | |||
|
|
|||
| These ideas are out of scope for *this* proposal. | |||
|
|
|||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 123: Summary of changes)PyType_GetModuleByDef📚 Documentation preview 📚: https://pep-previews--4453.org.readthedocs.build/pep-0793/