Add a comparison output style for GitHub tables #398
Closed
+29
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh, I'm having second thoughts about this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running benchmarks for a PR of mine, I noticed that
--output_style tableformats it in a way that GitHub doesn't know how to deal with. Instead of manually making one, I thought it would be much more convenient if there were a way to emit a GitHub-style table that could be directly copy-pasted to a comment. I guess this is technically a markdown table, but there's too many different parsers for markdown to conform to that standard.I didn't bother with adding padding or anything, so it looks like garbage in the terminal, but it looks fine on GitHub.