Add Android support #265
Add Android support #265
Conversation
There was a problem hiding this comment.
Based on the current state of python/cpython#137186, this makes sense to me
|
(Updated from |
There was a problem hiding this comment.
Let's set the defaults to a 3.14 commit, so we test Android for regular PRs and don't break it by mistake:
# Set from inputs for workflow_dispatch, or set defaults to test push/PR events
env:
GIT_REMOTE: ${{ github.event.inputs.git_remote || 'python' }}
GIT_COMMIT: ${{ github.event.inputs.git_commit || '48f88310044c6ef877f3b0761cf7afece2f8fb3a' }}
CPYTHON_RELEASE: ${{ github.event.inputs.cpython_release || '3.14.0rc1' }}
I agree, but that'll have to wait until there's a tag that includes the Android build action from python/cpython#137186. |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
python/cpython#137186 has been changed to use an |
|
I've updated I've also created python/peps#4541 to make the corresponding changes to PEP 101. Pending the merge of python/cpython#137186, I think this PR is now complete. |
select_jobs.py
Outdated
| # Android binary releases began in Python 3.14. | ||
| output("android", version.release >= (3, 14)) |
There was a problem hiding this comment.
(I guess technically they'll start in rc2 or rc3, but practically speaking I'm never going to do 3.14.0rc1 again :) And this much simplifies the logic.)
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
@mhsmith The candidate of release candidate 2 is now building Android, in case you want to check it: https://github.com/python/release-tools/actions/runs/16965004771 |
|
Looks good to me! |
This is a follow up for python#265 that added initial implementation with copy-pasted steps.
This is a follow up for python#265 that added initial implementation with copy-pasted steps.
This is a follow up for python#265 that added initial implementation with copy-pasted steps.
See the linked issue for details:
Since there will be no Android releases for Python 3.13 and earlier, the Android release job is skipped on those versions. See the "Temporarily point inputs ..." commit for a run that includes Android.
The lint and docs failures appear to be unrelated.